[Bug 639594] Review Request: scout - A CLI interface to Tomboy notes and Gnote

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=639594

--- Comment #6 from Damian Wrobel <dwrobel at ertelnet.rybnik.pl> 2010-10-10 13:12:08 EDT ---
Ankur,

Please find some initial comments.

- MUST: rpmlint must be run on every package. The output should be posted in
the review.

$ rpmlint scout-0.4-1.fc13.src.rpm 
scout.src: W: invalid-url Source0:
http://github.com/lelutin/scout/downloads/lelutin-scout-v0.4-0-ga2ae61f.tar.gz
HTTP Error 404: Not Found
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

Downloading the tarball I end up in the following location:
http://download.github.com/lelutin-scout-v0.4-0-ga2ae61f.tar.gz

NOT OK


- MUST: The package must be named according to the Package Naming Guidelines

It matches the original project name, but the name seems to be ambigous.
I found a completely different project with the same name[1], thus maybe
it would be reasonable to use the name of the original tarball to avoid
any possible clash?
On the other hand it looks the project has changed its name in the
past[2], maybe it will be changed again to more closely reflect its purpose to
e.g. [gnote|tomboy]-cli or something similar?
Maybe other packagers could help you in the final decision?


- MUST: The package must meet the Packaging Guidelines.

The package doesn't own all required directories as described in[3] e.g.:
/usr/lib/python2.6/site-packages/scout-0.4-py2.6.egg-info/
/usr/lib/python2.6/site-packages/scout/
/usr/lib/python2.6/site-packages/scout/actions/

NOT OK


- MUST: The License field in the package spec file must match the actual
license.

The spec file says that the license is "LGPLv2 and Copyright only"

LICENSE file claims that the software is GPLv2, except for "format-subst.pl"
which is under a GNU LGPLv2",

There is an information on the web page of the project[4] that all files are
under the BSD license except the format-subst.pl file which is under GPLv2.

The setup.py file mention that the license is BSD.

Additionally the projects' web page[4] says:
"A copy of the BSD license should be available with the source code. Also, a
short license notice can be found in all files."

But I couldn't find the BSD license included in the sources. Neither of source
file contains any license notice.

Could you please clarify all the issues with the author?

NOT OK



References:
[1]
http://rpmfind.net/linux/RPM/opensuse/factory/noarch/scout-0.1.0-42.2.noarch.html
[2] bug #583672, comment #15
[3] https://fedoraproject.org/wiki/Packaging:UnownedDirectories
[4] http://github.com/lelutin/scout

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.