[Bug 641485] Review Request: python26-simplejson - Simple, fast, extensible JSON encoder/decoder for Python

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=641485

Carl Thompson <fedora at red-dragon.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fedora at red-dragon.com

--- Comment #3 from Carl Thompson <fedora at red-dragon.com> 2010-10-10 13:50:29 EDT ---
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
See below - Meets Packaging Guidelines.
See below - License
OK - License field in spec matches
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
0bbe3a2e5e4cac040013733aca159d89  simplejson-2.1.1.tar.gz
0bbe3a2e5e4cac040013733aca159d89  simplejson-2.1.1.tar.gz

OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good.
See below - Package has a correct %clean section.
OK - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.
OK - Package has rm -rf RPM_BUILD_ROOT at top of %install

FAIL - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
OK - Package obey's FHS standard (except for 2 exceptions)
FAIL - No rpmlint output. 
 - final provides and requires are sane.

SHOULD Items:

FAIL - Should build in mock.
FAIL - Should build on all supported archs
OK - Should have dist tag
OK - Should package latest version
OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or
/usr/sbin

rpmlint python26-simplejson-2.1.1-1.fc13.src.rpm 
python26-simplejson.src: W: spelling-error %description -l en_US http -> HTTP
python26-simplejson.src: W: spelling-error %description -l en_US json -> son, j
son, Sonja
python26-simplejson.src: W: spelling-error %description -l en_US subclassed ->
subclasses, sub classed, sub-classed
1 packages and 0 specfiles checked; 0 errors, 3 warnings

rpm requires python26 and that is not a package distributed with rawhide
packages need all their requirements to be supplied by rawhide
possibly submit python26 as a package or use python3 for the requirement for
this package

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.