[Bug 639991] Review Request: rubygem-rb-inotify - A Ruby wrapper for Linux's inotify, using FFI

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=639991

--- Comment #3 from Michal Fojtik <mfojtik at redhat.com> 2010-10-11 08:02:52 EDT ---
(In reply to comment #2)
> Some notes:
> 
> * Unused macro
>   - Please remove unused macro defined in the spec file
> 
> * Explicit dependency
>   - ">= 0.5.0" part on "Requires: rubygem(ffi)" is not needed
>     because rubygem-ffi packages on currently supported branches
>     on Fedora all satisfy this version dependency.
> 
> * %files
>   - The directory %geminstdir itself is not owned by any
>     packages.
> 
>   - The following files should also be %doc
> -------------------------------------------------------
> %{geminstdir}/Rakefile
> %{geminstdir}/rb-inotify.gemspec
> -------------------------------------------------------

* Mon Oct 11 2010 Michal Fojtik <mfojtik at patashnik> - 0.8.1-2
- Removed unused macros
- Moved Rakefile into doc

Spec URL: http://mifo.sk/RPMS/rubygem-rb-inotify.spec
SRPM URL: http://mifo.sk/RPMS/rubygem-rb-inotify-0.8.1-2.fc13.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.