[Bug 638647] Review Request: mom - Dynamically manage system resources on virtualization hosts

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=638647

Xavier Bachelot <xavier at bachelot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |xavier at bachelot.org

--- Comment #2 from Xavier Bachelot <xavier at bachelot.org> 2010-10-11 18:37:44 EDT ---
A couple comments :
- in file section, %(_bindir)/usr/sbin/momd should be %{_sbindir}/momd
- files in /usr/share/doc/mom/examples should rather be installed in
%{_docdir}/%{name}-%{version} and thus you won't need to specify it as %doc
- %doc is missing the COPYING file

trimmed rpmlint output :
mom.src:4: W: mixed-use-of-spaces-and-tabs (spaces: line 4, tab: line 4)
mom.x86_64: E: no-binary
mom.x86_64: E: non-executable-script
/usr/lib/python2.6/site-packages/mom/Collectors/GuestNetworkDaemon.py 0644L
/usr/bin/env
mom.x86_64: W: service-default-enabled /etc/rc.d/init.d/momd
mom.x86_64: E: malformed-line-in-lsb-comment-block # system resources
mom.x86_64: W: incoherent-subsys /etc/rc.d/init.d/momd $prog
mom.x86_64: W: service-default-enabled /etc/rc.d/init.d/momd
mom-debuginfo.x86_64: E: empty-debuginfo-package


- please fix space/tabs issue
- package should be noarch
- service shouldn't be enabled by default
- remove broken LSB line in initscript


Also, if this is your first package, you need to be sponsored and thus this bug
needs to block FE-NEEDSPONSOR.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.