[Bug 642637] Review Request: antlr-maven-plugin - Maven plugin that generates files based on grammar file(s)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=642637

Colin Walters <walters at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |walters at redhat.com

--- Comment #2 from Colin Walters <walters at redhat.com> 2010-10-13 09:39:46 EDT ---
(not a full review)

# svn checkout https://svn.codehaus.org/mojo/tags/antlr-maven-plugin-2.1
antlr-maven-plugin
# find antlr-maven-plugin -depth -name .svn -type d -exec rm -rf {} \;

"svn export"?

Patch0:   maven-antlr-plugin-2.1-modello-issue.patch
Patch1:   maven-antlr-plugin-2.1-artifact.patch
Patch2:   maven-antlr-plugin-2.1-sinkfix.patch

Each of these should have a rationale comment:
https://fedoraproject.org/wiki/Packaging:Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment

(Though personally I've switched to using git format-patch patches for
upstreams which use git, since it allows longer explanations and as a bonus
makes it easy for upstream to merge the patch; but in this case upstream is
svn)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.