[Bug 639098] Review Request: rubygem-gtk2 - Ruby binding of GTK+-2.x

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=639098

Michal Fojtik <mfojtik at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #2 from Michal Fojtik <mfojtik at redhat.com> 2010-10-13 10:45:36 EDT ---
Review:

First, %prep stage must contain %setup -q -c -T to create the directory where C
libraries are compiled.

[OK]

Then at %build stage the Ruby Gem must be installed under the directory created
at %prep stage to get C libraries compiled under there.

[OK]

When gem install is used to install Gem file, using -V option is recommend to
check if CFLAGS is correctly honored.

[OK], -O2 used correctly.

Finally at %install stage the whole tree under the directory created at %prep
stage should be copied (not moved) to under %{buildroot}%{gemdir}.

[OK]

Installed C codes (usually under %{geminstdir}/etc) may be removed even if gem
contents %{gemname} reports that installed C codes should be found there.

[OK]

Packages that contain Ruby Gems must be called rubygem-%{gemname} where gemname
is the name from the Gem's specification.

[OK]

The Source of the package must be the full URL to the released Gem archive; the
version of the package must be the Gem's version

[OK]

The package must have a Requires and a BuildRequires on rubygems

[OK]

The package must provide rubygem(%{gemname}) where gemname is the name from the
Gem's specification.

[OK]

For every dependency on a Gem named gemdep, the package must contain a Requires
on rubygem(%{gemdep}) with the same version constraints as the Gem

[OK]

Mock build and specfile looks clean to me.

REVIEW+

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.