[Bug 642524] Review Request: rubygem-net-sftp - A pure Ruby implementation of the SFTP client protocol

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=642524

--- Comment #3 from Michal Fojtik <mfojtik at redhat.com> 2010-10-14 07:01:57 EDT ---
(In reply to comment #1)
> Taking this one. Overall looks good with some small nits
> 
> * rpmlint complains about mixing spaces / tabs, please remove the tab on line
> 25
> "Summary:  Documentation for %{name}"

Fixed.

Now:

rpmlint rubygem-net-sftp-2.0.5-2.fc13.noarch.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

rpmlint rubygem-net-sftp-doc-2.0.5-2.fc13.noarch.rpm
rubygem-net-sftp-doc.noarch: W: no-documentation
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

rpmlint rubygem-net-sftp-2.0.5-2.fc13.src.rpm
rubygem-net-sftp.src: W: no-buildroot-tag
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

> 
> * Can you please change %source0 to point to the official rubygems.org gem

Fixed.

> 
> * The license of the documentation file should be MIT and LGPLv2 as the
> setup.rb is licensed under the LGPL version 2.1

Fixed. I write down a comment in %files to mark setup.rb file as LGPL

> These are the only blockers, though I was also wondering why you specify ">
> 1.2" for the rubygems dependency (not wrong, just haven't see this before).

You're right. I removed that version dependency.

> Also if you have a moment the review guidelines state "If the source package
> does not include license text(s) as a separate file from upstream, the packager
> SHOULD query upstream to include it", not a biggie though.

Sure, will do :-)

> 
> 
> Rpmlint looks fine (with the exception above), the package builds fine on koji,
> and I did a surface functionality test.
> 
> Once the three blockers have been resolved about, this package is ready.
> 
> 
> APPROVED rubygem-net-sftp  [mmorsi]

Thanks for help and review!

========================

* Thu Oct 14 2010 Michal Fojtik <mfojtik at redhat.com> - 2.0.5-2
- Fixed license
- Fixes source0 URL

Spec URL: http://mifo.sk/RPMS/rubygem-net-sftp.spec
SRPM URL: http://mifo.sk/RPMS/rubygem-net-sftp-2.0.5-2.fc13.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.