[Bug 642577] Review Request: rubygem-open4 - Manage child processes and their IO handles easily
bugzilla at redhat.com
bugzilla at redhat.com
Thu Oct 14 15:29:35 UTC 2010
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=642577
Jozef Zigmund <jzigmund at redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag|needinfo?(jzigmund at redhat.c |
|om) |
--- Comment #3 from Jozef Zigmund <jzigmund at redhat.com> 2010-10-14 11:29:34 EDT ---
MUST: rpmlint must be run on every package. The output should be posted in the
review.
rpmlint rubygem-open4-1.0.1-1.fc13.src.rpm
rubygem-open4.src: W: spelling-error %description -l en_US pid -> peed, dip,
pud
rubygem-open4.src: W: spelling-error %description -l en_US stdin -> stein,
stain, stdio
rubygem-open4.src: W: spelling-error %description -l en_US stdout -> stout, std
out, std-out
rubygem-open4.src: W: spelling-error %description -l en_US stderr -> std err,
std-err, stander
rubygem-open4.src: W: no-buildroot-tag
1 packages and 0 specfiles checked; 0 errors, 5 warnings.
[OK]
Each Ruby package MUST indicate the Ruby ABI version it depends on with a line
like:
Requires: ruby(abi) = 1.8
[OK - this MUST condition is written via macro in this spec file]
Packages that contain Ruby Gems MUST be called rubygem-%{gemname} where gemname
is the name from the Gem's specification.
%global gemname open4
Name: rubygem-%{gemname}
[OK]
The Source of the package MUST be the full URL to the released Gem archive
URL: http://github.com/ahoward/open4/tree/master
Source0: http://gems.rubyforge.org/gems/%{gemname}-%{version}.gem
[OK]
The version of the package MUST be the Gem's version
Version: 1.0.1
[OK]
The package MUST have a Requires and a BuildRequires on rubygems
%global rubyabi 1.8
Requires: ruby(abi) = %{rubyabi}
Requires: rubygems
BuildRequires: rubygems
[OK]
The Gem MUST be installed into %{gemdir} defined as:
%global gemdir %(ruby -rubygems -e 'puts Gem::dir' 2>/dev/null)
[OK]
If the Gem only contains pure Ruby code, it MUST be marked as BuildArch: noarch
BuildArch: noarch
[OK]
The package MUST own the following files and directories:
%{gemdir}/gems/%{gemname}-%{version}/
%{gemdir}/cache/%{gemname}-%{version}.gem
%{gemdir}/specifications/%{gemname}-%{version}.gemspec
[OK]
The install SHOULD be performed with the command
gem install --local --install-dir %{buildroot}%{gemdir} --force %{SOURCE0}
[OK]
Note: At the end of %description is '.' character and i'm not sure if it's OK.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list