[Bug 642856] Review Request: drupal-flexifilter - Allows non-admins to create their own, configurable custom filters

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=642856

--- Comment #3 from Eric Christensen <eric at christensenplace.us> 2010-10-15 08:53:02 EDT ---
* MUST: rpmlint must be run on every package. The output should be posted in
the review.[1]
[christensene at mini Desktop]$ rpmlint drupal-flexifilter-6.x.1.2-1.fc14.src.rpm 
drupal-flexifilter.src: W: spelling-error %description -l en_US regex ->
regexp, remex, reg ex
drupal-flexifilter.src: W: spelling-error %description -l en_US extendable ->
expendable, extend able, extend-able
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

[christensene at mini Desktop]$ rpmlint drupal-flexifilter.spec 
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

PASSED although you may want to file a ticket upstream to get the spelling
corrected.

* MUST: The package must be named according to the Package Naming Guidelines.
PASSED based on the fact that Drupal never changes the "X" to anything else.

Still need to update the SOURCE1, which means a slight work around in the SPEC,
I believe.

Paul pointed out that your %define at the top shoudl be changed to
%{_datadir}/drupal6 and the name of the module should be changed to
drupal6-flexifilter.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.