[Bug 641093] Review Request: keybinder - A library for registering global keyboard shortcuts

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=641093

Martin Gieseking <martin.gieseking at uos.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.gieseking at uos.de

--- Comment #1 from Martin Gieseking <martin.gieseking at uos.de> 2010-10-15 15:05:47 EDT ---
Hi Hannes,

here are some initial comments:

- According to the source file headers, the license of the library and the
  Lua bindings is MIT. Only the Python bindings are GPLv2+.
  Thus, you should adapt the License fields accordingly. Also, add file
  COPYING to the python subpackage.

- The %description lines should not exceed 80 characters.

- The summary of the python package should start with a capital letter.

- Add a filter to prevent providing the python library:
  %filter_provides_in %{python_sitearch}.*\.so$
  %filter_setup
  For further details see
  https://fedoraproject.org/wiki/Packaging:AutoProvidesAndRequiresFiltering

- add %postun -p /sbin/ldconfig

- drop empty file ChangeLog

- in %files, replace %{_libdir}/libkeybinder.so* with 
  %{_libdir}/libkeybinder.so.* to prevent packaging the .so file which belongs
  in the devel package

- add %{_libdir}/libkeybinder.so to the devel package

- remove _keybinder.la from the python subpackage

- I think the Lua binding library should go in a lua subpackage.



$ rpmlint /var/lib/mock/fedora-13-x86_64/result/*.rpm
keybinder.src: W: spelling-error %description -l en_US lua -> la, luau, lea
keybinder.src: E: description-line-too-long C keybinder is a library for
registering global keyboard shortcuts. Keybinder works
keybinder.x86_64: W: spelling-error %description -l en_US lua -> la, luau, lea
keybinder.x86_64: E: description-line-too-long C keybinder is a library for
registering global keyboard shortcuts. Keybinder works
keybinder.x86_64: E: zero-length /usr/share/doc/keybinder-0.2.2/ChangeLog
keybinder.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libkeybinder.so
keybinder.x86_64: E: library-without-ldconfig-postun
/usr/lib64/libkeybinder.so.0.0.1
keybinder-devel.x86_64: W: no-documentation
python-keybinder.x86_64: W: summary-not-capitalized C keybinder python bindings
python-keybinder.x86_64: W: private-shared-object-provides
/usr/lib64/python2.6/site-packages/keybinder/_keybinder.so
_keybinder.so()(64bit)
python-keybinder.x86_64: W: no-documentation
5 packages and 0 specfiles checked; 4 errors, 7 warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.