[Bug 639594] Review Request: scout - A CLI interface to Tomboy notes and Gnote

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=639594

Damian Wrobel <dwrobel at ertelnet.rybnik.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |dwrobel at ertelnet.rybnik.pl
               Flag|fedora-review?              |fedora-review+

--- Comment #26 from Damian Wrobel <dwrobel at ertelnet.rybnik.pl> 2010-10-16 11:32:29 EDT ---
Package Review
--------------

Key:
+ = ACCEPTED, Not Applicable
- = NEEDSWORK, PROBLEM

--- REQUIRED ITEMS ---

[+] MUST: rpmlint must be run on every package... [1]
[+] MUST: The package must be named according to the Package Naming...
[+] MUST: The spec file name must match the base package %{name}, ...
[+] MUST: The package must meet the Packaging Guidelines .
[+] MUST: The package must be licensed with a Fedora approved license and...
[+] MUST: The License field in the package spec file must match the actual...
[+] MUST: If (and only if) the source package includes the text of the ...
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream... [2]
[+] MUST: The package MUST successfully compile and build into binary rpms ...
[+] MUST: If the package does not successfully compile, build or work on an ...
[+] MUST: All build dependencies must be listed in BuildRequires, except for...
[+] MUST: The spec file MUST handle locales properly. This is done by using ...
[+] MUST: Every binary RPM package (or subpackage) which stores shared...
[+] MUST: Packages must NOT bundle copies of system libraries.
[+] MUST: If the package is designed to be relocatable, the packager must...
[+] MUST: A package must own all directories that it creates.
[+] MUST: A Fedora package must not list a file more than once in the spec...
[+] MUST: Permissions on files must be set properly. Executables should be...
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable content.
[+] MUST: Large documentation files must go in a -doc subpackage.
[+] MUST: If a package includes something as %doc, it must not affect the...
[+] MUST: Header files must be in a -devel package.
[+] MUST: Static libraries must be in a -static package.
[+] MUST: If a package contains library files with a suffix...
[+] MUST: In the vast majority of cases, devel packages must require...
[+] MUST: Packages must NOT contain any .la libtool archives,...
[+] MUST: Packages containing GUI applications must include ...
[+] MUST: Packages must not own files or directories already owned by other...
[+] MUST: All filenames in rpm packages must be valid UTF-8.

--- SUGGESTED ITEMS ---

[+] SHOULD: If the source package does not include license text(s) as a ...
[+] SHOULD: The description and summary sections in the package spec file ...
[+] SHOULD: The reviewer should test that the package builds in mock. [3]
[+] SHOULD: The package should compile and build into binary rpms on all...
[+] SHOULD: The reviewer should test that the package functions as described.
[+] SHOULD: If scriptlets are used, those scriptlets must be sane.
[+] SHOULD: Usually, subpackages other than devel should require the base...
[+] SHOULD: The placement of pkgconfig(.pc) files depends on their usecase,...
[+] SHOULD: If the package has file dependencies outside of /etc, /bin, ...
[-] SHOULD: your package should contain man pages for binaries/scripts.

----------------
Package APPROVED
----------------

References:
[1]. rpmlint scout-0.4-6.fc13.src.rpm 
scout.src: W: invalid-url Source0:
http://download.github.com/lelutin-scout-v0.4-0-ga2ae61f.tar.gz HTTP Error 404:
Not Found
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

[2]. md5sum: 6fb9f618ac45094028e43d710db83982 
lelutin-scout-v0.4-0-ga2ae61f.tar.gz

[3]. http://koji.fedoraproject.org/koji/taskinfo?taskID=2538070

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.