[Bug 635450] Review Request: docky - MacOS-like docker app

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=635450

Christian Krause <chkr at plauener.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chkr at plauener.de

--- Comment #3 from Christian Krause <chkr at plauener.de> 2010-10-16 18:43:44 EDT ---
just some comments after a first quick look:

1. rpmlint of the binary package revealed:
docky.i686: W: invalid-license GPL
Please have a look at
http://fedoraproject.org/wiki/Packaging:LicensingGuidelines 
and
http://fedoraproject.org/wiki/Licensing
for the correct license tag.

2. if desktop-file-install is used then you don't need to call
desktop-file-validate:
http://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usage

3. the scriptlets for updating the gtk icon cache are not correct, please
check:
http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache

4. please re-check the build requirements, some of them (e.g. autoconf,
automake and libtool) are not necessary (they are only needed when the
configure script is actually rebuilt)

5. it looks like that docky brings its own gio-sharp with it - please can you
check whether the library from the system could be used?

6. please update to the newest upstream release

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.