[Bug 643392] Review Request: pyqtrailer - PyQt4 application to download trailers from apple.com

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=643392

--- Comment #1 from Petr Sabata <psabata at redhat.com> 2010-10-18 10:26:11 EDT ---
rpmlint output:
pyqtrailer.noarch: W: no-manual-page-for-binary pyqtrailer

OK; The package must be named according to the  Package Naming Guidelines
OK; The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
OK; The package must meet the  Packaging Guidelines
OK (GPLv3); The package must be licensed with a Fedora approved license and
meet the  Licensing Guidelines
OK; The License field in the package spec file must match the actual license.
OK; If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.
OK; The spec file must be written in American English.
OK; The spec file for the package MUST be legible.
OK (72801e8a880ed12a30510f5edcf5b107); The sources used to build the package
must match the upstream source, as provided in the spec URL.
OK; The package MUST successfully compile and build into binary rpms on at
least one primary architecture.
NA; If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch
OK; All build dependencies must be listed in BuildRequires, except for any that
are listed in the exceptions section of the Packaging Guidelines
OK; he spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
NA; Every binary RPM package (or subpackage) which stores shared library files
(not just symlinks) in any of the dynamic linker's default paths, must call
ldconfig in %post and %postun.
OK; Packages must NOT bundle copies of system libraries.
NA; If the package is designed to be relocatable, the packager must state this
fact in the request for review, along with the rationalization for relocation
of that specific package.
OK; A package must own all directories that it creates. If it does not create a
directory that it uses, then it should require a package which does create that
directory.
OK; A Fedora package must not list a file more than once in the spec file's
%files listings. (Notable exception: license texts in specific situations)
OK; Permissions on files must be set properly. Executables should be set with
executable permissions, for example. Every %files section must include a
%defattr(...) line.
OK; Each package must consistently use macros.
OK; The package must contain code, or permissable content.
NA; Large documentation files must go in a -doc subpackage.
OK; If a package includes something as %doc, it must not affect the runtime of
the application. 
NA; Header files must be in a -devel package.
NA; Static libraries must be in a -static package.
NA; If a package contains library files with a suffix (e.g. libfoo.so.1.1),
then library files that end in .so (without suffix) must go in a -devel
package.
NA; n the vast majority of cases, devel packages must require the base package
using a fully versioned dependency
OK; Packages must NOT contain any .la libtool archives, these must be removed
in the spec if they are built.
NOK; Packages containing GUI applications must include a %{name}.desktop file,
and that file must be properly installed with desktop-file-install in the
%install section.
OK; Packages must not own files or directories already owned by other packages. 
OK; All filenames in rpm packages must be valid UTF-8.

Summary:
.desktop file is missing
It would be nice to include a manpage (not provided by upstream, though),
however since this is a self-explanatory GUI application, I don't consider that
a blocker

Also, I won't approve this package until pytrailer (bug #643391) makes it to
Fedora.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.