[Bug 642583] Review Request: rubygem-rr - RR is a framework that features a rich selection of double techniques

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=642583

--- Comment #3 from Jozef Zigmund <jzigmund at redhat.com> 2010-10-20 09:08:08 EDT ---
This review it's just NONFORMAL because i'm not in Fedora Packager Group right
now.

MUST: The License field in the package spec file must match the actual license.
License: GPLv2+ or Ruby

[BAD - This gem have other license (MIT)]

MUST: rpmlint must be run on every package. The output should be posted in the
review.
rpmlint rubygem-rr-1.0.0-2.fc13.src.rpm 

rubygem-rr.src: W: no-buildroot-tag
rubygem-rr.src: W: patch-not-applied Patch0: %{name}-remove-bundler.patch
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

[It seems OK , but i'm not sure about 2nd warning]

Each Ruby package MUST indicate the Ruby ABI version it depends on with a line
like:
Requires: ruby(abi) = 1.8

[OK - this MUST condition is written via macro in this spec file]

Packages that contain Ruby Gems MUST be called rubygem-%{gemname} where gemname
is the name from the Gem's specification.

%global gemname rr
Name: rubygem-%{gemname}

[OK]

The Source of the package MUST be the full URL to the released Gem archive

URL: http://pivotallabs.com
Source0: http://gems.rubyforge.org/gems/%{gemname}-%{version}.gem

[OK]

The version of the package MUST be the Gem's version

Version: 1.0.0

[OK]

The package MUST have a Requires and a BuildRequires on rubygems

%global rubyabi 1.8

Requires: ruby(abi) = %{rubyabi}
Requires: rubygems
BuildRequires: rubygems
BuildRequires: rubygem(rspec)

[OK]

The Gem MUST be installed into %{gemdir} defined as:
%global gemdir %(ruby -rubygems -e 'puts Gem::dir' 2>/dev/null)

[OK]

If the Gem only contains pure Ruby code, it MUST be marked as BuildArch: noarch

BuildArch: noarch

[OK]

The package MUST own the following files and directories:

%{gemdir}/gems/%{gemname}-%{version}/
%{gemdir}/cache/%{gemname}-%{version}.gem
%{gemdir}/specifications/%{gemname}-%{version}.gemspec

[OK]

The install SHOULD be performed with the command

gem install --local --install-dir %{buildroot}%{gemdir} --force %{SOURCE0} 

[OK]

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.