[Bug 644708] Review Request: pymongo - Python driver for MongoDB

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=644708

--- Comment #4 from Silas Sewell <silas at sewell.ch> 2010-10-20 10:21:28 EDT ---
SRPM:
http://github.com/downloads/silas/rpms/pymongo-1.9-2.fc13.src.rpm

(In reply to comment #2)
> Just some comments for now:
> 
> - There was a guidelines change, so you are not allowed to disable the internal
> dependency generator (cvisualmodule is even not inside of this package ;-), but
> it's:
> pymongo.x86_64: W: private-shared-object-provides
> /usr/lib64/python2.7/site-packages/pymongo/_cmessage.so _cmessage.so()(64bit)
> pymongo-gridfs.x86_64: W: no-documentation
> python-bson.x86_64: W: private-shared-object-provides
> /usr/lib64/python2.7/site-packages/bson/_cbson.so _cbson.so()(64bit)

This should be fixed.

> - python-bson doesn't require the main package and contains no license. Either
> include the appropriate license or require the main package.
>   (didn't check for license issues yet)

I added the license to the subpackage.

> - This package cleanly compiles with python3, could you enable python3
> subpackages?
>   See: https://fedoraproject.org/wiki/Packaging:Python#Example_spec_file
>   (you need to run 2to3 --nobackups --write %{py3dir} thought)

The package compiles without error but doesn't actually work. I added the code
so its easy to try at a later point, but without the python-nose package
supporting python3 I wouldn't be comfortable enabling a database driver with
auto-magic code conversion (esp one with lots of C code).

That said, if someone else is interested in maintaing a patch for the pymongo
code and all the tests (they import nose) I might be willing to include it.

Upstream has a ticket for python3 support:
http://jira.mongodb.org/browse/PYTHON-84

> - maybe you want to run nosetests and add a %check section...
>   I don't know the internals of pymongo, but right now most tests are failing,
> so are you sure this package will work, once imported?

A bunch of the tests require an active MongoDB connection, I've created a check
section that excludes those tests (anything that imported get_connection) and
should at least pass now.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.