[Bug 644335] Review Request: rubygem-mustache - Mustache is a framework-agnostic way to render logic-free views
bugzilla at redhat.com
bugzilla at redhat.com
Wed Oct 20 16:56:10 UTC 2010
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=644335
--- Comment #2 from Jozef Zigmund <jzigmund at redhat.com> 2010-10-20 12:56:09 EDT ---
(In reply to comment #1)
> Some notes for -1:
>
> - Source0: http://rubygems.org/gems/%{gemname}-%{version}.gem
>
> Please this URL to: Source0: http://rubygems.org/downloads/%{}-%{version}.gem
>
I repair URL to Source0:
http://rubygems.org/downloads/%{gemname}-%{version}.gem, because in your URL
was typo.
> - Summary
>
> Please remove "Mustache is", it's unnecessarily here.
>
Removed.
> - Require
>
> Please add rubygem-sinatra to requires:
>
> ./lib/mustache/sinatra.rb:require 'sinatra/base
Add to spec file, Require: rubygem(sinatra)
NEW SPEC URL: http://st.fri.uniza.sk/~zigmundj/fedorapkg/rubygem-mustache.spec
NEW SRPM URL:
http://st.fri.uniza.sk/~zigmundj/fedorapkg/rubygem-mustache-0.11.2-2.fc13.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list