[Bug 641271] Review Request: openerp-client - Open Source ERP Client

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=641271

--- Comment #3 from Dan Horák <dan at danny.cz> 2010-10-21 09:17:15 EDT ---
There is a problem that must be resolved with upstream before we can continue -
the files in bin/SpiffGtkWidgets are licensed as "GPLv2 only" making them
incompatible with the rest of the project that is GPLv3+
(https://fedoraproject.org/wiki/Licensing#GPL_Compatibility_Matrix)

Other issues found during my review are
- the uploaded file has the first character in upper-case, but the content of
the srpm itself is fine, should be all lower-case
- cli_dir macro is defined but not used anywhere, please remove
- I'd personally use %{name} macro instead of the openerp-client string inside
the %build/%install/%files sections
- build in mock for rawhide and F-14 fails with
...
+ /usr/bin/python setup.py build
Error: Can not find dsextras or gtk.dsextras

- the --vendor option shouldn't be used in new packages
(https://fedoraproject.org/wiki/Packaging/Guidelines#desktop-file-install_usage)
- locales are not handled correctly, see
https://fedoraproject.org/wiki/Packaging/Guidelines#Handling_Locale_Files

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.