[Bug 642995] Review Request: rubygem-deltacloud-client - Deltacloud REST Client

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=642995

Jordan OMara <jomara at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?,             |fedora-review+
                   |needinfo?(jomara at redhat.com |
                   |)                           |

--- Comment #3 from Jordan OMara <jomara at redhat.com> 2010-10-26 13:20:49 EDT ---
Thanks for sponsoring me, Toshio!

Michal: everything looks good. There is one optional warning from rpmlint that
you might want to address, but otherwise nice work.

rpmlint output: good
package name : good
spec file name : good
Packaging Guidelines : good
license included (ASL2): good
sources match upstream : good
builds for me on F13 : good
build dependencies : good
locales: good
no shared system libraries : good
correct directory ownership : good
no duplicate file ownership : good
permissions : good
macros : good
documentation : good
rubygem specific build config : good

My only suggestion is the warning from rpmlint: 

   rubygem-deltacloud-client.spec: W: no-buildroot-tag

A BuildRoot directive is required for older distros (RHEL5), and would be
handy.

Good work!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.