[Bug 646573] Review Request: rubygem-whiskey_disk - Ruby tool for embarrassingly fast deployments

bugzilla at redhat.com bugzilla at redhat.com
Tue Oct 26 20:20:47 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=646573

Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |mtasaka at ioa.s.u-tokyo.ac.jp
               Flag|                            |fedora-review?

--- Comment #1 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> 2010-10-26 16:20:45 EDT ---
Some notes

* License
  - License tag for this packge should be "MIT".

* %files
  - The directory %geminstdir itself is not owned by any packages

! Enabling test
  - From $ rake -P, for this gem "$ rake test" does some
    test programs (it seems rubygem-bacon is needed).
    Would you consider to enable %check and execute this?

! File name in %_bindir
  - Maybe the name "wd" is too short for files under %_bindir
    (to avoid file name space conflict). Would you contact the
    upstream to make script name longer to something specific
    to this gem? (not a blocker)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list