[Bug 638647] Review Request: mom - Dynamically manage system resources on virtualization hosts

bugzilla at redhat.com bugzilla at redhat.com
Tue Oct 26 20:28:15 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=638647

--- Comment #7 from Xavier Bachelot <xavier at bachelot.org> 2010-10-26 16:28:14 EDT ---
Thanks for answering my comments, explanations are fine to me. You're almost
there, I expect this to be the last round of comments before the package is
ready for a formal review.

rpmlint output :

$ rpmlint mom-0.2.1-3.fc13.noarch.rpm
mom.noarch: W: spelling-error Summary(en_US) virtualization -> actualization,
visualization, conceptualization
mom.noarch: W: spelling-error %description -l en_US eg -> Eg, eh, e
mom.noarch: W: spelling-error %description -l en_US cgroups -> groups, c
groups, Citigroup
mom.noarch: E: non-executable-script
/usr/lib/python2.6/site-packages/mom/Collectors/GuestNetworkDaemon.py 0644L
/usr/bin/env
mom.noarch: W: no-manual-page-for-binary momd
mom.noarch: W: incoherent-subsys /etc/rc.d/init.d/momd $prog
1 packages and 0 specfiles checked; 1 errors, 5 warnings.

You can ignore spelling-error.
non-executable-script needs to be fixed, remove the useless shebang. See patch.
no-manual-page-for-binary can be fixed by adding a man page if you wish, but
that's certainly not a blocker, feel free to ignore.
incoherent-subsys is a false positive, ignore.

Also, you've misunderstood me about the example conf files. I would still move
them to %{_defaultdocdir}/%{name}-%{version} and remove
%{_defaultdocdir}/%{name}/examples/*. As is, it would left
%{_defaultdocdir}/%{name}/examples unowned anyway. See patch.

There's a typo in the %files section for the conf file. See patch.

Last thing, patches names are not correct. You should suffix them with the name
of the package rather than fedora. Less chances to collide with other patches
name.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list