[Bug 646181] Review Request: rubygem-gio2 - Ruby binding of gio-2.0.x

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=646181

Michael Stahnke <mastahnke at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review+

--- Comment #1 from Michael Stahnke <mastahnke at gmail.com> 2010-10-26 17:29:22 EDT ---
stahnma at olive /var/lib/mock/fedora-rawhide-i386/result> rpmlint *rpm
rubygem-gio2.i686: W: spelling-error Summary(en_US) gio -> goo, gi, go
rubygem-gio2.i686: W: spelling-error %description -l en_US gio -> goo, gi, go
rubygem-gio2.src: W: spelling-error Summary(en_US) gio -> goo, gi, go
rubygem-gio2.src: W: spelling-error %description -l en_US gio -> goo, gi, go
>> rubygem-gio2.src:96: W: macro-in-comment %{geminstdir}
>> rubygem-gio2.src:96: W: macro-in-comment %{ruby_sitearch}
rubygem-gio2.src: W: no-buildroot-tag
rubygem-gio2-devel.i686: W: no-documentation
rubygem-gio2-doc.i686: W: no-documentation
rubygem-gio2-doc.i686: W: unexpanded-macro
/usr/lib/ruby/gems/1.8/doc/gio2-0.90.4/ri/GLib/InputStream/pending%3d-i.yaml
%3d
rubygem-gio2-doc.i686: W: unexpanded-macro
/usr/lib/ruby/gems/1.8/doc/gio2-0.90.4/ri/GLib/File/eql%3f-i.yaml %3f
rubygem-gio2-doc.i686: W: unexpanded-macro
/usr/lib/ruby/gems/1.8/doc/gio2-0.90.4/ri/GLib/DesktopAppInfo/desktop_env%3d-c.yaml
%3d
rubygem-gio2-doc.i686: W: unexpanded-macro
/usr/lib/ruby/gems/1.8/doc/gio2-0.90.4/ri/GLib/FileInfo/directory%3f-i.yaml %3f
rubygem-gio2-doc.i686: W: unexpanded-macro
/usr/lib/ruby/gems/1.8/doc/gio2-0.90.4/ri/GLib/Resolver/default%3d-c.yaml %3d
rubygem-gio2-doc.i686: W: unexpanded-macro
/usr/lib/ruby/gems/1.8/doc/gio2-0.90.4/ri/GLib/Icon/eql%3f-i.yaml %3f
ruby-gio2.i686: W: no-documentation
>> ruby-gio2.i686: W: dangling-relative-symlink /usr/lib/ruby/site_ruby/1.8/gio2.rb ../../gems/1.8/gems/gio2-0.90.4/lib/gio2.rb
6 packages and 0 specfiles checked; 0 errors, 17 warnings.

The only things to look into are noted with ">>".  

* Omitted most not applicable guidelines
Package Name +
License +
Spec file in English and readable + 
Source MD5 matches upstream +
Builds in mock and koji +
No bundles of lib + 
Devel package requires base package +
Doc package usage and will allow running without doc +
PC files in devel package +
* Ruby Specific
Ruby ABI + 
Use of sitelib and sitearch +
Gem setup +


MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun.

It appears to me that you install
/usr/lib/ruby/site_ruby/1.8/i386-linux/gio2.so

My only caveat is that I am unsure if the path is a default linker's path.  I
don't think it is. 


The package looks good.  Do you have any good examples of using it?  I was
unable to test it's usage.  

Package rubygem-gio2 APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.