[Bug 614299] Review Request: python-ordereddict - Py2.7's new collections.OrderedDict that works in Python 2.4-2.6.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=614299

--- Comment #4 from Toshio Ernie Kuratomi <a.badger at gmail.com> 2010-10-27 22:09:40 EDT ---
Good:
* Named according to Guidelines
* License is MIT in source file and spec
* Spec file is readable
* No locales to process
* No shared libraries to process
* No bundled libraries
* Not relocatable
* Package owns all directories that it creates
* Files are not listed twice
* Permissions set correctly
* Macros used consistently
* Code, not content
* No doc files affect runtime
* Not a GUI package
* Does not own files from other packages
* All filenames utf-8
* Builds in koji with %doc removal and upstream's tarball

Needswork:
* Source does not match upstream.   There is an upstream tarball for this at
pypi:
  http://pypi.python.org/pypi/ordereddict
  - The tarball in the srpm does not match the tarball on pypi
* We should be sticking to 80 columns or less in spec files.  If the Summary is
longer than 80 columns, chances are that it's too long.
* %define should be changed to %global as %define inside of %{} is only working
due to an rpm bug.

rpmlint:
python-ordereddict.noarch: W: summary-ended-with-dot C A drop-in substitute for
Py2.7's new collections.OrderedDict that works in Python 2.4-2.6.
python-ordereddict.noarch: E: summary-too-long C A drop-in substitute for
Py2.7's new collections.OrderedDict that works in Python 2.4-2.6.

Don't need the period at the end, "A " at the beginning  Make it shorter. 
Something like "Implementation of Python 2.7's OrderedDict"

python-ordereddict.noarch: W: spelling-error %description -l en_US lookup ->
lockup, hookup, look up
python-ordereddict.noarch: W: spelling-error %description -l en_US repr ->
rept, rep, repro

These are fine.  Both are spelled correctly in their domain.

python-ordereddict.noarch: E: description-line-too-long C Drop-in substitute
for Py2.7's new collections.OrderedDict. The recipe has big-oh performance that
matches regular dictionaries (amortized O(1) insertion/deletion/lookup and O(n)
iteration/repr/copy/equality_testing).

Noted above.

python-ordereddict.noarch: W: no-documentation

If upstream provides no documentation we don't need to ship any

2 packages and 0 specfiles checked; 4 errors, 7 warnings.


Notes:
* Should query upstream to include license text

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.