[Bug 595697] Review Request: ghc-regex-tdfa - Haskell "tagged" DFA regex engine

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=595697

--- Comment #13 from Jens Petersen <petersen at redhat.com> 2010-10-28 03:42:13 EDT ---
Here is the review:

 +:ok,  NA: not applicable

MUST Items:
[+] MUST: rpmlint output:

ghc-regex-tdfa.src: W: spelling-error Summary(en_US) Haskell -> Gaskell,
Gaitskell, Skellum
ghc-regex-tdfa.src: W: spelling-error %description -l en_US libtre -> libre,
Liberec, librate
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
ghc-regex-tdfa.x86_64: W: spelling-error Summary(en_US) Haskell -> Gaskell,
Gaitskell, Skellum
ghc-regex-tdfa.x86_64: W: spelling-error %description -l en_US libtre -> libre,
Liberec, librate
ghc-regex-tdfa.x86_64: W: executable-stack
/usr/lib64/ghc-6.12.1/regex-tdfa-1.1.4/libHSregex-tdfa-1.1.4-ghc6.12.1.so
1 packages and 0 specfiles checked; 0 errors, 3 warnings.
ghc-regex-tdfa-devel.x86_64: W: spelling-error Summary(en_US) Haskell ->
Gaskell, Gaitskell, Skellum
ghc-regex-tdfa-devel.x86_64: W: spelling-error %description -l en_US libtre ->
libre, Liberec, librate
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
ghc-regex-tdfa-prof.x86_64: E: devel-dependency ghc-regex-tdfa-devel
ghc-regex-tdfa-prof.x86_64: W: spelling-error %description -l en_US libtre ->
libre, Liberec, librate
ghc-regex-tdfa-prof.x86_64: W: no-documentation
ghc-regex-tdfa-prof.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/ghc-6.12.1/regex-tdfa-1.1.4/libHSregex-tdfa-1.1.4_p.a
1 packages and 0 specfiles checked; 1 errors, 3 warnings.

[+] MUST: The package must be named according to the Package Naming Guidelines
[+] MUST: The spec file name must match base package %{name}
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines
[+] MUST: The License field in the package spec file must match the actual
license.
[+] MUST: include license files in %doc if included in source
[+] MUST: The spec file must be written in American English and be legible.
[+] MUST: source md5sum matches upstream release

877a98eb70bea7be07cbd33508758b70 
pkgreview/ghc-regex-tdfa/regex-tdfa-1.1.4.tar.gz

[+] MUST: must successfully compile and build into binary rpms on one main arch
[+] MUST: if necessary use ExcludeArch for other archs
[+] MUST: All build dependencies must be listed in BuildRequires
[NA] MUST: use %find_lang macro for .po translations
[NA] MUST: packages with shared library files in the dynamic linker's default
paths, must call ldconfig in %post and %postun.
[+] MUST: Packages must NOT bundle copies of system libraries.
[NA] MUST: If the package is designed to be relocatable, the packager must
state this fact in the request for review
[+] MUST: A package must own all directories that it creates, or require a
package which does create that directory.
[+] MUST: A package must not contain any duplicate files in the %files listing
(except license files if necessary).
[+] MUST: Permissions on files must be set properly. 
[+] MUST: Each package must consistently use macros
Follows standard Haskell packaging
[+] MUST: The package must contain code, or permissable content.
[NA] MUST: Large documentation files should go in a doc subpackage.
[+] MUST: If a package includes something as %doc, it must not affect the
runtime of the application.
[+] MUST: Header files must be in a -devel package.
[NA] MUST: Static libraries must be in a -static package.
[NA] MUST: If a package has library files with a suffix (e.g. libfoo.so.1.1),
then library files that end in .so (without suffix) must go in a -devel
package.
[+] MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency: Requires: %{name} =
%{version}-%{release} 
[+] MUST: Packages must NOT contain any .la libtool archives, these should be
removed in the spec.
[NA] MUST: Packages containing GUI applications must include a %{name}.desktop
file
[+] MUST: Packages must not own files or directories already owned by other
packages.
[+] MUST: All filenames in rpm packages must be valid UTF-8.

SHOULD Items:
[+] SHOULD: The reviewer should test that the package builds in mock.

http://koji.fedoraproject.org/koji/taskinfo?taskID=2561003

[+] SHOULD: The package should compile and build into binary rpms on all
supported architectures.
[+] SHOULD: If scriptlets are used, those scriptlets must be sane.

APPROVED

But please fix the common_description text with the patch that follows.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.