[Bug 645764] Review Request: django-addons - to add plugging functionality in your projects easier

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=645764

--- Comment #4 from Domingo Becker <domingobecker at gmail.com> 2010-10-28 15:51:33 EDT ---
(In reply to comment #1)
> 1. summary is too long, should not end with "." (see rpmlint)

Fixed.

> 2. I'd use URL: http://pypi.python.org/pypi/django-addons

It uses that URL now.

> 3. description is a bit short, see above URL for a longer one

Fixed.

> 4. Please split long lines to fit 80 cols (again, see rpmlint)

Fixed.

> 5. Use a full URL for Source, so "spectool -g django-addons.spec" will get it

Fixed.

> 6. Always prefer .gz or .bz2 archives when available

Fixed. It's using a tar.gz now.

> 7. .py files (or at least the ones I checked) does not include licensing info
> in the header, upstream should be notified this can later be source of issues.
> 8. The only licensing info I found (in PKG-INFO) says this is BSD, not ASL 2.0,
> am I missing something?

Fixed. 
It includes now a LICENCE file for the whole package.
This change needed a new update to be pushed to pypi.python.org which has been
done yesterday by upstream.

The new .spec reflects the use of the new version, and adds a small patch to
django_addons/models.py to remove an unterminated null string.

Spec URL: http://beckerde.fedorapeople.org/transifex/django-addons.spec
SRPM URL:
http://beckerde.fedorapeople.org/transifex/django-addons-0.6.2-1.fc13.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.