[Bug 647510] Review Request: premake - A cross-platform build configuration tool

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=647510

--- Comment #4 from Joachim de Groot <jdegroot at web.de> 2010-10-28 18:18:25 EDT ---
Thank you for your feedback!

(In reply to comment #3)
> I've just seen you added the « FE-NEEDSPONSOR » flag after I took
> your package. Since I'm not a sponsor, I won't be able to approve
> your package if necessary. Anyway I'll give you some comments.

Unfortunately, it took me a while to figure out how to get it there. 

I have added all your changes and additionally removed the 'A' from the summary
(read about that in the review of another package).

The new files are 
Spec URL: http://fedora.jaydg.nl/premake.spec
SRPM URL: http://fedora.jaydg.nl/premake-4.2.1-2.fc13.src.rpm


> 4) In %install, you don't need to use the absolute path to your build directory
>    to install the executable. The following line is enough:
>       %install
>       rm -rf %{buildroot}
>       install -Dp bin/release/premake4 %{buildroot}/%{_bindir}/premake4
>    Note that:
>    * %{_bindir} macro should be used instead of /usr/bin
>    * the -D option will create the destination folder if necessary, so a call
> to
>      mkdir before is useless
>    * the -p option will preserve timestamp
I was looking for an option to install that does not require naming the
executable again as target. That's why I came up with mkdir.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.