[Bug 647926] Review Request: xsettingsd - Provides settings to X11 clients via the XSETTINGS specification

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=647926

--- Comment #4 from Peter Lemenkov <lemenkov at gmail.com> 2010-10-30 04:13:22 EDT ---
The package is simple and in a very good shape - I found only two issues:

a) Versioning scheme is wrong. According to Fedora guidelines the proper scheme
should be:

Version:        0
Release:        0.1.20091208git%{commit_id}%{?dist}

Note that I'm using %{commit_id}, so it should be defined somewhere above this
line.

Also you should fix %changelog entry version accordingly, e.g.

* Fri Oct 29 2010 Pierre Carrier <prc at redhat.com> - 0-0.1.20091208git7804894

Note that you can't use macros with mutable values in %changelog (%{version},
%{release} or %{commit_id}) or all your change-log entries' records will be
recalculated each build.

b) You accidentally installed elf-binary instead of man-page at line 35. Proper
install directive should be

%{__install} -Dm0755 dump_xsettings.1    
%{buildroot}%{_mandir}/man1/dump_xsettings.1


Please fix these issues and I'll continue.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.