[Bug 647076] Review Request: jackbeat - audio sequencer

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=647076

Xavier Bachelot <xavier at bachelot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |xavier at bachelot.org

--- Comment #8 from Xavier Bachelot <xavier at bachelot.org> 2010-10-30 08:23:50 EDT ---
Few comments : 

- The icon png could be installed with one line rather than 2 :
  Replace
  %{__install} -m 755 -d %{buildroot}/%{_datadir}/pixmaps
  %{__install} -m 644 %{SOURCE1} %{buildroot}/%{_datadir}/pixmaps/
  with 
  %{__install} -Dp -m 644 %{SOURCE1}
%{buildroot}/%{_datadir}/pixmaps/%{name}.png

- if you remove all of %{buildroot}/%{_datadir}/%{name}/help no need to remove
%{buildroot}/%{_datadir}/%{name}/help/COPYING first. Also, just a wild guess,
make sure removing this file doesn't break an About box or something like that
in the software.

- The %files section could be much simpler and thus more readable. You want to
own everything in %{_datadir}/%{name} so just use that and remove all others
line starting with %{_datadir}/%{name}. %dir needs to be used only when you
want to own a directory but not what's inside it. Here's how the %files section
should look like :
%files 
%defattr(-,root,root,-)
%doc AUTHORS ChangeLog COPYING README NEWS
%{_bindir}/%{name}
%{_datadir}/%{name}
%{_datadir}/applications/%{name}.desktop
%{_datadir}/pixmaps/%{name}.png

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.