[Bug 591388] Review Request: pbuilder - Personal package builder for Debian packages

Sat Oct 30 21:59:21 UTC 2010

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=591388

--- Comment #2 from Christoph Wickert <cwickert at fedoraproject.org> 2010-10-30 17:59:19 EDT ---
REVIEW FOR pbuilder-0.196-1.fc13.src.rpm

FIX - MUST: 
pbuilder.noarch: W: spelling-error %description -l en_US chroot -> cheroot, ch
root, ch-root
pbuilder.noarch: W: spelling-error %description -l en_US debootstrap -> de
bootstrap, de-bootstrap, bootstrapped
pbuilder.noarch: W: spelling-error %description -l en_US dsc -> dc, sc, desc
pbuilder.noarch: E: description-line-too-long C "pbuilder update" updates the
image to the current state of testing/unstable/whatever
pbuilder.noarch: W: only-non-binary-in-usr-lib
pbuilder.noarch: W: spurious-executable-perm
/usr/share/doc/pbuilder-0.196/examples/B92test-pkg
pbuilder.noarch: W: spurious-executable-perm
/usr/share/doc/pbuilder-0.196/examples/pbuildd/hookdir/A10dpkg-l.sh
pbuilder.noarch: W: spurious-executable-perm
/usr/share/doc/pbuilder-0.196/examples/pbuilder-test/002_libfile
pbuilder.noarch: W: spurious-executable-perm
/usr/share/doc/pbuilder-0.196/examples/rebuild/buildall
pbuilder.noarch: W: spurious-executable-perm
/usr/share/doc/pbuilder-0.196/examples/D90chrootmemo
pbuilder.noarch: W: spurious-executable-perm
/usr/share/doc/pbuilder-0.196/examples/F90chrootmemo
pbuilder.noarch: W: spurious-executable-perm
/usr/share/doc/pbuilder-0.196/examples/execute_paramtest.sh
pbuilder.noarch: W: spurious-executable-perm
/usr/share/doc/pbuilder-0.196/examples/pbuilder-test/003_makecheck
pbuilder.noarch: W: spurious-executable-perm
/usr/share/doc/pbuilder-0.196/examples/pbuilder-test/000_prepinstall
pbuilder.noarch: W: spurious-executable-perm
/usr/share/doc/pbuilder-0.196/examples/pbuildd/buildd.sh
pbuilder.noarch: W: spurious-executable-perm
/usr/share/doc/pbuilder-0.196/examples/B90list-missing
pbuilder.noarch: W: spurious-executable-perm
/usr/share/doc/pbuilder-0.196/examples/D80no-man-db-rebuild
pbuilder.noarch: W: spurious-executable-perm
/usr/share/doc/pbuilder-0.196/examples/D10tmp
pbuilder.noarch: W: spurious-executable-perm
/usr/share/doc/pbuilder-0.196/examples/D20addnonfree
pbuilder.noarch: W: spurious-executable-perm
/usr/share/doc/pbuilder-0.196/examples/pbuilder-test/004_ldd
pbuilder.noarch: W: spurious-executable-perm
/usr/share/doc/pbuilder-0.196/examples/workaround/E50-initscripts-2.86.ds1-7.workaround.sh
pbuilder.noarch: W: spurious-executable-perm
/usr/share/doc/pbuilder-0.196/examples/execute_installtest.sh
pbuilder.noarch: W: spurious-executable-perm
/usr/share/doc/pbuilder-0.196/examples/workaround/G50-initscripts-2.86.ds1-11-cdebootstrap0.3.9.sh
pbuilder.noarch: W: spurious-executable-perm
/usr/share/doc/pbuilder-0.196/examples/C10shell
pbuilder.noarch: W: spurious-executable-perm
/usr/share/doc/pbuilder-0.196/examples/B90lintian
pbuilder.noarch: W: spurious-executable-perm
/usr/share/doc/pbuilder-0.196/examples/pbuilder-distribution.sh
pbuilder.noarch: W: spurious-executable-perm
/usr/share/doc/pbuilder-0.196/examples/pbuilder-test/001_apprun
pbuilder.noarch: W: spurious-executable-perm
/usr/share/doc/pbuilder-0.196/examples/lvmpbuilder/lvmbuilder
pbuilder.noarch: W: spurious-executable-perm
/usr/share/doc/pbuilder-0.196/examples/rebuild/getlist
pbuilder.noarch: W: spurious-executable-perm
/usr/share/doc/pbuilder-0.196/examples/B91debc
pbuilder.noarch: W: spurious-executable-perm
/usr/share/doc/pbuilder-0.196/examples/B91dpkg-i
pbuilder.noarch: W: spurious-executable-perm
/usr/share/doc/pbuilder-0.196/examples/C11screen
pbuilder.noarch: W: no-manual-page-for-binary debuild-pbuilder
pbuilder.noarch: W: no-manual-page-for-binary pdebuild-user-mode-linux
pbuilder.noarch: W: no-manual-page-for-binary pdebuild
pbuilder.noarch: W: no-manual-page-for-binary pbuilder-user-mode-linux
pbuilder.noarch: W: no-manual-page-for-binary pbuilder
pbuilder.src: W: spelling-error %description -l en_US chroot -> cheroot, ch
root, ch-root
pbuilder.src: W: spelling-error %description -l en_US debootstrap -> de
bootstrap, de-bootstrap, bootstrapped
pbuilder.src: W: spelling-error %description -l en_US dsc -> dc, sc, desc
pbuilder.src: E: description-line-too-long C "pbuilder update" updates the
image to the current state of testing/unstable/whatever
pbuilder.src:70: E: hardcoded-library-path in %{_prefix}/lib/%{name}
pbuilder.src: W: invalid-url Source0:
http://ftp.de.debian.org/debian/pool/main/p/pbuilder/pbuilder_0.196.tar.gz HTTP
Error 404: Not Found
2 packages and 0 specfiles checked; 3 errors, 40 warnings.

Can be ignored: spelling-error, no-manual-page-for-binary,
only-non-binary-in-usr-lib, hardcoded-library-path

Need to be fixed: description-line-too-long, spurious-executable-perm

OK - MUST: named according to the Package Naming Guidelines
OK - MUST: spec file name matches the base package %{name}
OK - MUST: package meets the Packaging Guidelines
OK - MUST: Fedora approved license and meets the Licensing Guidelines
FIX - MUST: License field in spec file matches the actual license: GPL is no
valid license
FIX - MUST: license file included in %doc: no license included
OK - MUST: spec is in American English
OK - MUST: spec is legible
TBD - MUST: sources match the upstream source by MD5
OK - MUST: successfully compiles and builds into binary rpms on x86_64
N/A - MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch.
OK - MUST: all build dependencies are listed in BuildRequires.
N/A - MUST: handles locales properly with %find_lang
N/A - MUST: Every binary RPM package (or subpackage) which stores shared
library files (not just symlinks) in any of the dynamic linker's default paths,
must call ldconfig in %post and %postun.
OK - MUST: Package does not bundle copies of system libraries.
N/A - MUST: If the package is designed to be relocatable, the packager must
state this fact in the request for review, along with the rationalization for
relocation of that specific package.
OK - MUST: owns all directories that it creates
OK - MUST: no duplicate files in the %files listing
OK - MUST: Permissions on files are set properly, includes %defattr(...)
OK - MUST: consistently uses macros
OK - MUST: package contains code, or permissable content
N/A - MUST: Large documentation files should go in a -doc subpackage
OK - MUST: Files included as %doc do not affect the runtime of the application
N/A - MUST: Header files must be in a -devel package
N/A - MUST: Static libraries must be in a -static package
N/A - MUST: library files that end in .so are in the -devel package.
N/A - MUST: devel packages must require the base package using a fully
versioned dependency
OK - MUST: The package does not contain any .la libtool archives.
N/A - MUST: Packages containing GUI applications must include a %{name}.desktop
file, and that file must be properly installed with desktop-file-install in the
%install section.
OK - MUST: package does not own files or directories already owned by other
packages.
OK - Should: at the beginning of %install, the package runs rm -rf
%{buildroot}.
OK - MUST: all filenames valid UTF-8

SHOULD Items:
FIX - SHOULD: Source package includes license text(s) as a separate file.
N/A - SHOULD: The description and summary sections in the package spec file
should contain translations for supported Non-English languages, if available.
OK - SHOULD: builds in mock.
OK - SHOULD: compiles and builds into binary rpms on all supported
architectures.
OK - SHOULD: functions as described.
N/A - SHOULD: Scriptlets are sane.
N/A - SHOULD: Usually, subpackages other than devel should require the base
package using a fully versioned dependency.
N/A - SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg
OK - SHOULD: no file dependencies outside of /etc, /bin, /sbin, /usr/bin, or
/usr/sbin
N/A - SHOULD: package should contain man pages for binaries/scripts.

Other items:
Fix - not latest stable version, upstream is already at 0.199
OK - SourceURL valid
OK - Compiler flags ok
OK - Debuginfo complete
OK - SHOULD: package has a %clean section, which contains rm -rf %{buildroot}.
N/A - SHOULD: Packages containing pkgconfig(.pc) files must 'Requires:
pkgconfig'.

TODO items:
- please update the package to 0.199 so I can check the TBD points.

- fix the FIX items

- use the full allowed 80 characters for the lines in description, but not more

- %doc %{_datadir}/doc -> %{_docdir}

- include docs: AUTHORS, ChangeLog, COPYING, README, THANKS

- build and include the mapages (pbuilder-uml.conf refers to man 5
pbuilder-uml.conf)

- Create and own /var/cache/pbuilder/pbuildd/

- Missing Requires: sudo

- usr/bin/pdebuild requires dpkg-parsechangelog, dpkg-architecture and
dpkg-buildpackage, thus we need dpkg-devel instead of just dpkg

- usr/bin/debuild-pbuilder requires usr/bin/debuild from Debian's devscripts
package

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.