[Bug 641093] Review Request: keybinder - A library for registering global keyboard shortcuts

bugzilla at redhat.com bugzilla at redhat.com
Sun Oct 31 10:34:28 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=641093

--- Comment #6 from Dominic Hopf <dmaphy at fedoraproject.org> 2010-10-31 06:34:27 EDT ---
$ rpmlint keybinder.spec
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

$ rpmlint keybinder-0.2.2-3.fc14.src.rpm
keybinder.src: W: spelling-error %description -l en_US lua -> la, luau, lea
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

This spelling error can safely be ignored.

$ rpmlint *keybinder*
keybinder.x86_64: W: spelling-error %description -l en_US lua -> la, luau, lea
keybinder-devel.x86_64: W: no-documentation
lua-keybinder.x86_64: W: no-documentation
5 packages and 0 specfiles checked; 0 errors, 3 warnings.


Package Review
==============

Key:
 - = N/A
 x = Check
 ! = Problem
 ? = Not evaluated

=== REQUIRED ITEMS ===
 [x] Package is named according to the Package Naming Guidelines
 [x] Specfile name matches %{name}.spec
 [x] Package seems to meet Packaging Guidelines
 [x] Package successfully compiles and builds into binary RPMs on at least one
     supported architecture.
     Tested on: Fedora 14/x86_64
 [x] Rpmlint output:
     source RPM: see above
     binary RPM: see above
 [x] Package is not relocatable.
 [!] License in specfile matches actual License and meets Licensing Guidelines
     The tarball provides a file COPYING containing the GPLv2+, the README file
     also points to GPLv2+.

     The file ax_lua.m4 in the m4/ directory says GPLv3+.

  This results in GPLv3+ for any file marked with a GPLv2+ or GPLv3+ hint
  in it.

  The file lua-keybinder/lkeybinder.c is MIT, thus the lua subpackage
  should be tagged with "License: MIT".

  Any file in libkeybinder/ is also MIT. Since there is no subpackage for
  the library, this results in tagging the main package with MIT, yes.

  But: as there are GPLv3+ files in the main package also (I'm referring
  to m4/ax_lua.m4) - even if they are just part of the source RPM - which
  were not moved to any subpackage, you will have to tag the main package
  with "License: MIT and GPLv3+".

  Of course, alternatively you can ask upstream if this is intended and if
  they may fix the license of m4/ax_lua.m4.

     Feel free to correct me if it seems I may understood something wrong.

 [x] License file is included in %doc.
 [x] Specfile is legible and written in AE
 [x] Sourcefile in the Package is the same as provided in the mentioned Source
     SHA1SUM of Source: 9e7e62727fd236f2d3c49cc9ff1eaadc78841987
 [x] Package compiles successfully
 [x] All build dependencies are listed in BuildRequires
 [-] Specfile handles locales properly
 [x] ldconfig called in %post and %postun if required
 [x] Package owns directorys it creates
 [-] Package requires other packages for directories it uses.
 [x] Package does not list a file more than once in the %files listing
 [x] %files section includes %defattr and permissions are set properly
 [x] %clean section is there and contains rm -rf %{buildroot}
 [x] Macros are consistently used
 [x] Package contains code, or permissable content.
 [-] Large documentation files are in a -doc subpackage
 [x] Program runs properly without files listed in %doc
 [x] Header files are in a -devel package
 [-] Static libraries are in a -static package
 [!] Package requires pkgconfig if .pc files are present
  The "Requires: pkgconfig" should be added, at least for the -devel subpackage

 [x] .so-files are put into a -devel subpackage
 [!] Subpackages include fully versioned dependency for the base package
  The python and lua subpackage lacks the %{release} dependency

 [x] Any libtool archives (*.la) are removed
 [-] contains desktop file (%{name}.desktop) if it is a GUI application
 [x] Package does not own files or directories owned by other packages.
 [x] %{buildroot} is removed at beginning of %install
 [-] Filenames are encoded in UTF-8

=== SUGGESTED ITEMS ===
 [x] Package contains latest upstream version
 [x] Package does not include license text files separate from upstream.
 [-] non-English translations for description and summary
 [x] Package builds in mock
     Tested on: F14/x86_64
 [x] Package should compile and build into binary RPMs on all supported
     architectures.
     tested build with koji
 [?] Program runs
  Keybinder is basically a library and can not be run directly.

 [-] Scriptlets must be sane, if used.
 [x] pkgconfig (*.pc) files are placed in a -devel package
 [-] require package providing a file instead of the file itself
     no files outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin are required

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list