[Bug 636654] Review Request: Gorm - The GNUstep graphical interface builder

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=636654

Michel Alexandre Salim <fedora at michelsylvain.info> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |needinfo?(jochen at herr-schmi
                   |                            |tt.de)

--- Comment #2 from Michel Alexandre Salim <fedora at michelsylvain.info> 2010-10-31 10:44:29 EDT ---
License field needs updating, a tiny spelling error, and the spec file needs to
be untabified; after that this review can be approved

* TODO Review [80%]
** DONE Names [2/2]
*** DONE Package name
*** DONE Spec name
** DONE Meets
[[http://fedoraproject.org/wiki/Packaging/Guidelines][guidelines]]
** DONE source files match upstream
   - md5sum: 7b068a369051f83d450d2a0dd464e8ee
** TODO License [2/3]
*** DONE License is Fedora-approved
*** FAIL License field accurate
    - Should be GPLv3+ not GPLv2+
*** DONE License included iff packaged by upstream
** TODO rpmlint [0/2]
*** FAIL on src.rpm
    - gorm.src:12: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line
12)
      Minor problem, please untabify
*** FAIL on x86_64.rpm
    - http://koji.fedoraproject.org/koji/taskinfo?taskID=2567020
    - gorm.x86_64: W: no-manual-page-for-binary Gorm
      - can be ignored
    - gorm-devel.x86_64: W: no-documentation
      - can be ignored
    - gorm-doc.noarch: W: spelling-error %description -l en_US Thsi -> Thai, Th
si, Th-si
      - this should be changed to "This"
** DONE Language & locale [3/3]
*** DONE Spec in US English
*** DONE Spec legible
*** N/A Use %find_lang to handle locale files
** DONE Build [3/3]
*** DONE Koji results
*** DONE BRs complete
*** DONE Directory ownership
** DONE Spec inspection [10/10]
*** DONE ldconfig for libraries
*** DONE No duplicate files
*** DONE File permissions
*** DONE Filenames must be UTF-8
*** DONE Has %clean section
    (except F-13+:
    https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean) 
*** DONE %buildroot cleaned on %install
*** DONE Macro usage consistent
*** DONE Documentation [2/2]
**** DONE If large docs, separate -doc
**** DONE %doc files are non-essential
*** DONE Development [5/5]
**** DONE Headers in -devel
**** DONE If versioned .so's, unversioned in -devel
**** N/A Static only if necessary, put in -static
**** DONE -devel, -static requires main
**** DONE No .la
*** N/A Other subpackages
** N/A Desktop file validation
** N/A
[[http://fedoraproject.org/wiki/Packaging/ScriptletSnippets][Scriptlets]]

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.