[Bug 226155] Merge Review: mod_perl

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226155

--- Comment #15 from Emmanuel Seyman <emmanuel.seyman at club-internet.fr> 2010-10-31 13:04:57 EDT ---
(In reply to comment #12)
>
> Yup, I've just been busy these last two weeks and haven't had time to spare to
> reviews. I'll make time by the end of the week.

Well, make that next week. :-)

(In reply to comment #10)
>
> mod_perl.src: W: spelling-error %description -l en_US perl -> Perl, peel, perk

False positive.

> mod_perl.src: W: spelling-error %description -l en_US runtime -> run time,
> run-time, runtish

Fixed.

> mod_perl.src: W: strange-permission filter-provides.sh 0755L
> mod_perl.src: W: strange-permission filter-requires.sh 0755L

Removed (see below).

> mod_perl.src:59: W: rpm-buildroot-usage %build PREFIX=$RPM_BUILD_ROOT/usr \

Not fixed (and harmless, imho).

> mod_perl.src:108: W: macro-in-comment %{_mandir}
> mod_perl.src:109: W: macro-in-comment %{perl_vendorarch}

Removed.

> mod_perl.src:59: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line 59)

Ugh. Fixed.

> mod_perl.i386: E: useless-provides perl(Apache2::Connection)
> mod_perl.i386: E: useless-provides perl(Apache2::RequestRec)

Filtered. I also moved the filtering inline.

> mod_perl.i386: W: hidden-file-or-dir
> /usr/share/doc/mod_perl-2.0.4/docs/devel/debug/code/.debug-inline
> mod_perl.i386: W: hidden-file-or-dir
> /usr/share/doc/mod_perl-2.0.4/docs/devel/debug/code/.debug-modperl-register
> mod_perl.i386: W: hidden-file-or-dir
> /usr/share/doc/mod_perl-2.0.4/docs/devel/debug/code/.debug-modperl-xs
> mod_perl.i386: E: wrong-script-interpreter

False postives.

> /usr/share/doc/mod_perl-2.0.4/docs/os/win32/mpinstall C:/Perl/bin

False positive.

> mod_perl.i386: W: file-not-utf8
> /usr/share/doc/mod_perl-2.0.4/docs/devel/debug/c.pod
> mod_perl.i386: W: file-not-utf8 /usr/share/doc/mod_perl-2.0.4/Changes
> mod_perl.i386: W: hidden-file-or-dir
> /usr/share/doc/mod_perl-2.0.4/docs/devel/debug/code/.debug-modperl-init
> mod_perl.i386: W: file-not-utf8
> /usr/share/doc/mod_perl-2.0.4/docs/user/Changes.pod
> mod_perl.i386: W: file-not-utf8 /usr/share/doc/mod_perl-2.0.4/SVN-MOVE
> mod_perl.i386: W: file-not-utf8
> /usr/share/doc/mod_perl-2.0.4/docs/devel/core/explained.pod

All fixed.

> mod_perl.i386: W: no-manual-page-for-binary mp2bug

Probably something to report to upstream.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.