[Bug 645863] Review Request: python-oauth2 - Python support for improved oauth

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=645863

Arun SAG <sagarun at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |sagarun at gmail.com
               Flag|                            |fedora-review+

--- Comment #1 from Arun SAG <sagarun at gmail.com> 2010-10-31 13:20:55 EDT ---
[+] OK
[X] NOT OKAY
[-] NA


[+] Package meets naming and packaging guidelines
[+] Spec file matches base package name.
[+] Spec has consistant macro usage.
[+] Meets Packaging Guidelines.
[+] License
[+] License field in spec matches
[+] License file included in package
[+] Spec in American English
[+] Spec is legible.
[+] Sources match upstream md5sum:
[zer0c00l at gnubox SOURCES]$ md5sum  oauth2-1.1.3.tar.gz
79ab3c0af3a6295a699f37d0c25239db  oauth2-1.1.3.tar.gz



[-] Package needs ExcludeArch
[+] BuildRequires correct
[-] Spec handles locales/find_lang
[-] Package is relocatable and has a reason to be.
[+] Package has %defattr and permissions on files is good.
[-] Package has a correct %clean section.
[+] Package has correct buildroot
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
[+] Package is code or permissible content.
[-] Doc subpackage needed/used.
[-] Packages %doc files don't affect runtime.

[-] Headers/static libs in -devel subpackage.
[-] Spec has needed ldconfig in post and postun
[-] .pc files in -devel subpackage/requires pkgconfig
[-] .so files in -devel subpackage.
[-] -devel package Requires: %{name} = %{version}-%{release}
[-] .la files are removed.

[-] Package is a GUI app and has a .desktop file

[+] Package compiles and builds on at least one arch.
[+] Package has no duplicate files in %files.
[+] Package doesn't own any directories other packages own.
[+] Package owns all the directories it creates.

[+] No rpmlint output : ignorable
[zer0c00l at gnubox oauth2-1.1.3]$ rpmlint
~/rpmbuild/RPMS/noarch/python-oauth2-1.2.1-1.fc13.noarch.rpm 
python-oauth2.noarch: W: spelling-error Summary(en_US) oauth -> oath, auth, o
auth
python-oauth2.noarch: W: spelling-error %description -l en_US oauth -> oath,
auth, o auth
python-oauth2.noarch: W: spelling-error %description -l en_US py -> pt, p, y


[+] Should build in mock.
[+] Should build on all supported archs
[+] Should function as described.
[-] Should have sane scriptlets.
[-] Should have subpackages require base package with fully versioned depend.
[+] Should have dist tag
[+] Should package latest version
[+] check for outstanding bugs on package. (For core merge reviews)

XXX NOTE XXX

Getting deprecation warning from python-httplib2 when importing oauth2 module

In [1]: import oauth2
/usr/lib/python2.6/site-packages/httplib2/__init__.py:44: DeprecationWarning:
the sha module is deprecated; use the hashlib module instead
  import sha

Everything seems fine except deprecation warning.


XXXXXXXX Approved XXXXXXXXXX

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.