[Bug 628030] Review Request: maven-ant-tasks - Allow Maven artifact handling features to be used from within an Ant build

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=628030

--- Comment #4 from Stanislav Ochotnicky <sochotni at redhat.com> 2010-09-01 05:06:57 EDT ---
(In reply to comment #3)
> * Mon Aug 30 2010 Orion Poplawski <orion at cora.nwra.com> 2.1.1-3
> - Fix description typo
> - Fix javadoc package group
> - Add license to javadoc package
> - Make javadoc dir versioned with link
> - Own maven files, not the dirs
> - Use new maven names in BRs

Nice,

you are missing some more cases of maven2/poms instead of mavenpomdir, but
that's just nitpicking from my side.

> I could not get -Dmaven2.jpp.depmap.file to work, at least for
> plexus-container-default.  I don't think a pom/JPP link is installed for the
> 1.0 version.

Actually that situation is exactly why depmaps exist. It just tells maven "if
someone looks for this dependency, pretend it's this file I gave you"

I believe your depmap should look something like this:
<dependencies>
    <dependency>
        <maven>
            <groupId>org.codehaus.plexus</groupId>
            <artifactId>plexus-container-default</artifactId>
            <version>1</version>
        </maven>
        <jpp>
            <groupId>JPP/plexus</groupId>
            <artifactId>container-default</artifactId>
            <version>1</version>
        </jpp>
    </dependency>
</dependencies>

But I haven't tested this.

> maven-ant-tasks.src:137: E: files-attr-not-set

You put LICENSE above defattr macro this is the only MUST item for me to be
able to approve package, but it would be nice to have depmap too :-)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.