[Bug 226075] Merge Review: libXinerama

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226075

--- Comment #12 from Parag AN(पराग) <panemade at gmail.com> 2010-09-01 10:31:18 EDT ---
(In reply to comment #11)
> (In reply to comment #10)
> > 1) buildroot should be removed
> 
> Any references for this? I don't see a guideline that says buildroot should be
> removed.

 My understanding to reference
http://fedoraproject.org/wiki/PackagingGuidelines#BuildRoot_tag is that if
buildroot tag is ignored then why to unnecessarily write them in spec files.

> > 2) %clean not needed anymore

 reference to http://fedoraproject.org/wiki/PackagingGuidelines#.25clean

> > 3) cleaning of buildroot at start of %install also not needed

  Again reference to
http://fedoraproject.org/wiki/PackagingGuidelines#BuildRoot_tag this cleaning
of buildroot is now implicit.

> > 
> 
> 'Not needed' doesn't mean 'Must be removed'. It is the packager's choice to
> keep them. We have to respect that.

Sure that is why I suggest them. So its upto maintainer whether to accept above
3 changes or not.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.