[Bug 490940] Review Request: pubcookie - Open-source software for intra-institutional web authentication

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=490940

--- Comment #6 from Rafael Aquini <aquini at linux.com> 2010-09-01 19:40:40 EDT ---
Gabriel,
Please consider the following review observations:

Good:
* License in sources and spec is APL 2.0 which is open source
* License text included in the tarball and listed on %file.
* Spec is legible and American English
* http://www.pubcookie.org/downloads/pubcookie-3.3.4a.tar.gz
* Source matches upstream
* No locale files
* No shared libraries misplaced
* No bundled libraries
* Not relocatable
* No directories created unowned
* No duplicate files
* Default permissions are set
* Package is code
* No large documentation
* No %doc files are used at runtime
* No header files
* Not a GUI application
* Does not own files or directories from other packages
* All filenames are utf8

NEEDSWORK:
[1] rpmlint complaints:
    [rpmbuilder at localhost ~]$ rpmlint
/var/lib/mock/fedora-12-i386/result/pubcookie-3.3.4a-1.fc12.i686.rpm
/var/lib/mock/fedora-12-i386/result/pubcookie-server-3.3.4a-1.fc12.i686.rpm
/var/lib/mock/fedora-12-i386/result/pubcookie-3.3.4a-1.fc12.src.rpm 
    pubcookie.i686: W: spelling-error Summary(en_US) intra -> intr, intro,
infra
    pubcookie.i686: W: invalid-url URL: http://pubcookie.org <urlopen error
timed out>
    pubcookie.i686: W: no-manual-page-for-binary keyclient
    pubcookie-server.i686: W: invalid-url URL: http://pubcookie.org <urlopen
error timed out>
    pubcookie-server.i686: E: arch-dependent-file-in-usr-share
/usr/share/pubcookie/cgi-bin/index.cgi
    pubcookie-server.i686: W: no-manual-page-for-binary keyserver
    pubcookie.src: W: spelling-error Summary(en_US) intra -> intr, intro, infra
    pubcookie.src: W: invalid-url URL: http://pubcookie.org <urlopen error
timed out>
    pubcookie.src: W: invalid-url Source0:
http://pubcookie.org/downloads/pubcookie-3.3.4a.tar.gz <urlopen error timed
out>
    3 packages and 0 specfiles checked; 1 errors, 8 warnings.


[2] As a package which relies on httpd, pubcookie rpms & spec should be named
mod_pubcookie to correct follow the naming guidelines. See:

http://fedoraproject.org/wiki/PackageNamingGuidelines#Addon_Packages_.28httpd.2C_pam.2C_and_SDL.29


[3] Does not Build in mock for rawhide, F13 & F14  -- check the attachments for
mock rawhide buildlog.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.