[Bug 625242] Review Request: clustershell - Efficient cluster administration

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=625242

Martin Gieseking <martin.gieseking at uos.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.gieseking at uos.de

--- Comment #7 from Martin Gieseking <martin.gieseking at uos.de> 2010-09-02 10:43:21 EDT ---
Hi Stephane,

your package already looks pretty good. Here are just a couple of further
things to consider:

- it's sufficient to use "%setup -q" in %prep

- I recommend to place the vim files in %{_datadir}/vim/vimfiles/syntax and
  %{_datadir}/vim/vimfiles/ftdetect, respectively. Thus, it's not necessary to
  detect the current vim version and the corresponding folder name. Also, you
  can drop BR: vim-common

- For proper directory ownership, I suggest to create a -vim subpackage 
  containing the .vim files. This package should require vim-common in order
  to create the vim data directories. 

- Your package should also own the directory %{_sysconfdir}/clustershell and
  not only its contents. Otherwise, rpm won't remove the directory when
  uninstalling the package. Hence, add %dir %{_sysconfdir}/clustershell to the 
  %files section.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.