[Bug 529278] Review Request: eclipse-ptp - Eclipse Parallel Tools Platform

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=529278

--- Comment #38 from Andrew Overholt <overholt at redhat.com> 2010-09-02 21:49:35 EDT ---
(In reply to comment #37)
> http://koji.fedoraproject.org/koji/taskinfo?taskID=2443893

I got these RPMs and it installs fine.  The upgrade from the existing
eclipse-photran packages works, too.

You've shown that it builds in koji which is great.  I'm satisfied that build
and install items in the review checklist are good to go.

rpmlint still complains about a bunch of stuff (see attachment for full
details):

eclipse-photran.noarch: I: enchant-dictionary-not-found en_US

No idea what's up here.

eclipse-ptp.noarch: W: incoherent-version-in-changelog 4.0.3-0.2.v201009010938
['4.0.3-0.2.RC2b.fc15', '4.0.3-0.2.RC2b']

Please fix this.

As for the other rpmlint errors and warnings, I'm fine with the zero-length
files if they're stubs but would like to see upstream queried as to why they're
shipping them.  The .c/.h files as you said are compiled on target machines so
they're fine to ship as is.  I wonder if upstream doesn't know about p2
touchpoints to do chmod operations ... either way, I don't see a big deal with
the configure and various .sh scripts not having the execute bit set.

eclipse-ptp.src: W: strange-permission finddeps.sh 0755L
eclipse-ptp.src: W: strange-permission makesource.sh 0755L

These are fine in my book since you use them to generate stuff for the build.

eclipse-ptp.src: W: invalid-url Source0: org.eclipse.ptp-ptp_4_0.tar.gz

I don't know what's wrong with this.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.