[Bug 624660] Review Request: rakudo-star - Rakudo, Perl6-modules, Blizkost and documentation

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=624660

--- Comment #18 from Marcela Mašláňová <mmaslano at redhat.com> 2010-09-03 07:52:48 EDT ---
I didn't find where are configured CFLAGS. They should use RPM_OPT_FLAGS. -g is
set in different variable then CFLAGS, so that might be reason why some files
are not compiled with -g.

I will continue with formal review according to list, because it looks like all
right except debuginfo.

- rpmlint checks return:
rpmlint *
rakudo-star.i686: W: no-manual-page-for-binary parrot-blizkost
Not a problem.
rakudo-star-debuginfo.i686: E: debuginfo-without-sources
Working on.
rakudo-star.src: W: invalid-url Source1: rakudo.desk.in.tar.gz
Should be added in upstream, but that's really not a blocker.

- package meets naming guidelines
- package meets packaging guidelines
- license (Artistic 2.0) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream abdadbc3016498c3bd8a89b53f63ae35
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
! macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- .desktop files are ok

Nitpick: please use consistent macros s/${RPM_BUILD_ROOT}/$RPM_BUILD_ROOT/
%define DESK_TARGET ${RPM_BUILD_ROOT}%{_datadir}/applications/

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.