[Bug 629027] Review Request: python-ZODB3 - Zope Object Database: Object Database and Persistence

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=629027

--- Comment #2 from Chen Lei <supercyper1 at gmail.com> 2010-09-04 03:09:26 EDT ---
1.
# deal with header files
for MOD in BTrees persistent; do
  mkdir -p $RPM_BUILD_ROOT%{_includedir}/python%{py_ver}/$MOD/
  mv $RPM_BUILD_ROOT%{python_sitearch}/$MOD/*.h \
     $RPM_BUILD_ROOT%{_includedir}/python%{py_ver}/$MOD/
done

It seems those header files are useless and can be deleted as the *.c files.

2. 
I suggest to remove all lines which are useless for F13+.

%include %{_rpmconfigdir}/macros.python
%if ! (0%{?fedora} > 12 || 0%{?rhel} > 5)
%{!?python_sitearch: %global python_sitearch %(%{__python} -c "from
distutils.sysconfig import get_python_lib; print(get_python_lib(1))")}
%endif

BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

3.

for script in src/{ZODB,ZEO}/{zeoctl.py,scripts/{*.py,*/*.py}}; do
  if head -n 1 "$script" | grep -q '#!'; then
    sed -i '1,1d' "$script"
  fi
done

It seems the below lines is bit complicated, there are some other simple
alternatives available in packgaing trick. 


https://fedoraproject.org/wiki/Packaging_tricks#Remove_shebang_from_files

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.