[Bug 628631] Review Request: rubygem-httparty - Makes HTTP fun! Also, makes consuming restful web services dead easy

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=628631

--- Comment #2 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> 2010-09-06 12:29:54 EDT ---
Some notes:

! BR(check)
  - From ./spec/spec_helper.rb :
--------------------------------------------------------
     1  require File.join(File.dirname(__FILE__), '..', 'lib', 'httparty')
     2  require 'spec/autorun'
     3  require 'fakeweb'
--------------------------------------------------------
    For BR(check): rubygem(fakeweb) seems also needed. I hope someone
    will package this.

* Requires
  - Usually ">= 0.1.8" on "R: rubygem(crack)" is not needed (is usually
removed)
    because rubygem-crack on currently supported Fedora branches all satisfy
    this dependency, ref:
    https://fedoraproject.org/wiki/Packaging/Guidelines#Explicit_Requires

    However, looking at gemspecfile, httparty-0.6.1.gemspec contains:
--------------------------------------------------------
    29      if Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.2.0') then
    30        s.add_runtime_dependency(%q<crack>, ["= 0.1.8"])
--------------------------------------------------------
    So for this case, I suggest
    - to make the dependency for rubygem(crack) strict (i.e. use
      "R: rubygem(crack) = 0.1.8"
    - or remove strict version dependency for rubygem-crack on gemspec file

By the way, would you import rubygem-crack also for F-14/13?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.