[Bug 589867] Review Request: logcheck - analyzes logfiles and sends email

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=589867

--- Comment #17 from Peter Robinson <pbrobinson at gmail.com> 2010-09-06 15:03:40 EDT ---
Sorry for the delay. There's a few issues that need to be addressed

+ rpmlint output

 rpmlint logcheck*
logcheck.noarch: W: non-standard-uid /var/lib/logcheck logcheck
logcheck.noarch: W: non-standard-gid /var/lib/logcheck logcheck
logcheck.noarch: E: non-standard-dir-perm /var/lib/logcheck 0700L
logcheck.noarch: E: non-standard-dir-perm /etc/logcheck/cracking.d 02750L
logcheck.noarch: E: non-standard-dir-perm /etc/logcheck/violations.ignore.d
02750L
logcheck.noarch: E: non-readable /etc/logcheck/logcheck.logfiles 0640L
logcheck.noarch: E: non-standard-dir-perm /etc/logcheck/ignore.d.server 02750L
logcheck.noarch: E: non-standard-dir-perm /etc/logcheck/ignore.d.paranoid
02750L
logcheck.noarch: E: non-readable /etc/logcheck/logcheck.conf 0640L
logcheck.noarch: W: non-standard-uid /var/lock/logcheck logcheck
logcheck.noarch: W: non-standard-gid /var/lock/logcheck logcheck
logcheck.noarch: E: non-standard-dir-perm /var/lock/logcheck 0700L
logcheck.noarch: W: non-standard-gid /etc/logcheck logcheck
logcheck.noarch: E: non-standard-dir-perm /etc/logcheck 0750L
logcheck.noarch: E: non-standard-dir-perm /etc/logcheck/ignore.d.workstation
02750L
logcheck.noarch: E: non-standard-dir-perm /etc/logcheck/violations.d 02750L
logcheck.noarch: E: non-standard-dir-perm /etc/logcheck/cracking.ignore.d
02750L
logcheck.noarch: W: manual-page-warning /usr/share/man/man1/Logcheck.8.gz 1:
warning: `\"' not defined
logcheck.noarch: W: no-manual-page-for-binary logcheck
logcheck.src: W: invalid-url Source0:
http://ftp.de.debian.org/debian/pool/main/l/logcheck/logcheck_1.3.11.tar.gz
HTTP Error 404: Not Found
logcheck.spec: W: invalid-url Source0:
http://ftp.de.debian.org/debian/pool/main/l/logcheck/logcheck_1.3.11.tar.gz
HTTP Error 404: Not Found
2 packages and 1 specfiles checked; 12 errors, 9 warnings.

+ package name satisfies the packaging naming guidelines
+ specfile name matches the package base name
+ package should satisfy packaging guidelines
+ license meets guidelines and is acceptable to Fedora
+ license matches the actual package license
- latest version packaged
  version 1.3.13 is available

+ %doc includes license file
+ spec file written in American English
+ spec file is legible
- upstream sources match sources in the srpm
  packaged version doesn't seem to be available any longer
+ package successfully builds on at least one architecture
  tested using koji scratch build
+ BuildRequires list all build dependencies
n/a %find_lang instead of %{_datadir}/locale/*
n/a binary RPM with shared library files must call ldconfig in %post and
%postun+ does not use Prefix: /usr
+ package owns all directories it creates
+ no duplicate files in %files
+ Package perserves timestamps on install
- Permissions on files must be set properly
  rpmlint complains about a number of permissions
+ %defattr line
+ consistent use of macros
+ package must contain code or permissible content
n/a large documentation files should go in -doc subpackage
+ files marked %doc should not affect package runtime 
n/a header files should be in -devel
n/a static libraries should be in -static
n/a packages containing pkgconfig (.pc) files need 'Requires: pkgconfig'
n/a libfoo.so must go in -devel
n/a devel must require the fully versioned base
n/a packages should not contain libtool .la files
n/a packages containing GUI apps must include %{name}.desktop file
+ packages must not own files or directories owned by other packages
+ filenames must be valid UTF-8

Optional:

+ if there is no license file, packager should query upstream to include it
n/a translations of description and summary for non-English languages, if
available
+ reviewer should build the package in mock/koji
+ the package should build into binary RPMs on all supported architectures
  package built using koji scratch build
n/a review should test the package functions as described
+ scriptlets should be sane
n/a non -devel packages should require fully versioned base
n/a pkgconfig files should go in -devel
  shouldn't have file dependencies outside /etc /bin /sbin /usr/bin or
/usr/sbin
+ Package should have man files

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.