[Bug 567348] Review Request: dreampie - A graphical cross-platform interactive Python shell

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=567348

--- Comment #13 from Robin Lee <robinlee.sysu at gmail.com> 2010-09-07 08:31:25 EDT ---
* 'rpmlint must be run on every package. The output should be posted in the
review.', quoted from https://fedoraproject.org/wiki/Packaging:ReviewGuidelines

* Add '# The entire source code is GPLv3+ except'

* Relative path should be used to declare license, for example, use
'dreampielib/gui/SimpleGladeApp.py' instead of just the file name
'SimpleGladeApp.py'.

* py_zipimport.py is not found in the source of this release.

* 'LGPLv2.1+' should be 'LGPLv2+'

* BuildRoot tag can be removed.

* md5 matched.
$ md5sum dreampie-1.1.tar.gz 
57ced153616069ca6c3c7d37bb30633a  dreampie-1.1.tar.gz

* Should instruct users to install dreampie-python3 when they want to use
dreampie with Python3. The proper way is to include a README.Fedora file.

* In this case, subpackage name can be defined through '%package python3'.

* In %description, a comma should be added before 'etc.'

* The summary of the subpackage is not accurate.

* The main rpm should own '%{_datadir}/%{name}/'.

* The subpackage should specify requirement of Python interpreter through
'python(abi)' not 'python3'.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.