[Bug 591365] Review Request: libexplain - Library functions to explain system call errors

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=591365

--- Comment #6 from Martin Gieseking <martin.gieseking at uos.de> 2010-09-08 12:05:19 EDT ---
Here are some (minor) comments:

- Package "explain" doesn't need to require the base package. libexplain is 
  picked up automatically as a dependency.

- The %{optflags} are not required in "make install"

- The manpages are licensed under GPLv3+. Thus, the -devel package should get
  the License tag: LGPLv3+ and GPLv3+

- There's an issue in explain_output.3 reported by rpmlint:
  libexplain-devel.i686: W: manual-page-warning
/usr/share/man/man3/explain_output.3.gz 25: warning: `XX' not defined

You can fix it with the following patch:

--- a/man/man3/explain_output.3
+++ b/man/man3/explain_output.3
@@ -19,10 +19,10 @@
 .ds n) explain_output
 .TH explain_output 3
 .SH NAME
+explain_output \- output error messages
 .if require_index \{
-explain_output \- output error messages
+.XX "explain_output(3)" "output error messages"
 .\}
-.XX "explain_output(3)" "output error messages"
 .SH SYNOPSIS
 .ft CW
 #include <libexplain/output.h>

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.