[Bug 226015] Merge Review: libgnomekbd

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226015

Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |RAWHIDE
               Flag|fedora-review?              |fedora-review+
        Last Closed|                            |2010-09-09 05:43:46

--- Comment #1 from Parag AN(पराग) <panemade at gmail.com> 2010-09-09 05:43:46 EDT ---
Review:
koji Build =>http://koji.fedoraproject.org/koji/buildinfo?buildID=183515

+ rpmlint output for SRPM and for RPM.
ibgnomekbd.src: W: no-buildroot-tag
libgnomekbd.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/libgnomekbdui.so.4.2.0 ['/usr/lib64']
libgnomekbd.x86_64: W: non-conffile-in-etc
/etc/gconf/schemas/desktop_gnome_peripherals_keyboard_xkb.schemas
libgnomekbd.x86_64: W: dangerous-command-in-%pre rm
libgnomekbd.x86_64: W: dangerous-command-in-%post rm
libgnomekbd-devel.x86_64: W: no-documentation
libgnomekbd-capplet.x86_64: W: spelling-error Summary(en_US) plugins -> plug
ins, plug-ins, plugging
libgnomekbd-capplet.x86_64: W: spelling-error %description -l en_US plugins ->
plug ins, plug-ins, plugging
libgnomekbd-capplet.x86_64: E: binary-or-shlib-defines-rpath
/usr/bin/gkbd-indicator-plugins-capplet ['/usr/lib64']
libgnomekbd-capplet.x86_64: W: no-documentation
libgnomekbd-capplet.x86_64: W: no-manual-page-for-binary
gkbd-indicator-plugins-capplet
4 packages and 0 specfiles checked; 2 errors, 9 warnings.

+ source files match upstream url (sha1sum)
fb3bebc174986996859265fa119060e6db852601  libgnomekbd-2.31.5.tar.bz2

+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present which is not needed now.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ libgnomekbd.pc and libgnomekbdui.pc file present.
+ -devel and -capplet subpackage exists
+ no .la files.
+ translations are available
+ Does owns the directories it creates.
+ ldconfig and GConf2 scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.

Suggestions:
1) Following new changes can be implemented.
 a) %clean not needed
 b) cleaning of buildroot at start of %install also not needed

APPROVED libgnomeui-2.24.3-1.fc14.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.