[Bug 618354] Review Request: cwallpaper - A front end for fbsetbg, Esetroot, feh, and other wallpaper changers

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=618354

--- Comment #3 from Germán Racca <gracca at gmail.com> 2010-09-09 18:53:18 EDT ---
Many thanks to Ralph and Martin for the review and suggestions!

Ralph:

* I'm packaging the last version for GTK+, which is 0.3.2, to be consistent
with Gnome desktop, and because I like GTK more than FLTK :). Also this version
works perfectly well (at least for me).

* Well, I've added the cleaning of buildroot because in the future someone else
could take this package and maintain it for EPEL (but not me, because I'm not
interested in, at least by now).

* I've changed the Summary as you suggested.

* I've also mailed upstream suggesting to add a man page.

Martin:

* The cleaning of buildroot and the buildroot tag are preserved because as I
said above someone else could take this package for EPEL in the future.

* I've modified the %description as you suggested.

* I can't connect to this site: http://manualinux.my-place.us/cwallpaper.html.
I'm going to continue to try later.

Thanks again folks!

Please find updated files here:

SPEC: http://skytux.fedorapeople.org/packages/cwallpaper.spec

SRPM: http://skytux.fedorapeople.org/packages/cwallpaper-0.3.2-3.fc13.src.rpm
________________________________________________________________________________

rpmlint output:

Checking RPM package (cwallpaper-0.3.2-3.fc13.i686.rpm)
--------------------
cwallpaper.i686: W: spelling-error Summary(en_US) fbsetbg -> setback, subset,
besetting
cwallpaper.i686: W: spelling-error Summary(en_US) feh -> eh, fee, fen
cwallpaper.i686: W: spelling-error %description -l en_US fbsetbg -> setback,
subset, besetting
cwallpaper.i686: W: spelling-error %description -l en_US bsetbg -> subset,
setback, basset
cwallpaper.i686: W: spelling-error %description -l en_US esetroot -> beetroot,
esotropia, restroom
cwallpaper.i686: W: spelling-error %description -l en_US feh -> eh, fee, fen
cwallpaper.i686: W: spelling-error %description -l en_US config -> con fig,
con-fig, configure
cwallpaper.i686: W: no-manual-page-for-binary cwallpaper
1 packages and 0 specfiles checked; 0 errors, 8 warnings.

Checking DEBUG package (cwallpaper-debuginfo-0.3.2-3.fc13.i686.rpm)
----------------------
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

Checking SPEC file (cwallpaper.spec)
------------------
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

Checking SRPM package (cwallpaper-0.3.2-3.fc13.src.rpm)
---------------------
cwallpaper.src: W: spelling-error Summary(en_US) fbsetbg -> setback, subset,
besetting
cwallpaper.src: W: spelling-error Summary(en_US) feh -> eh, fee, fen
cwallpaper.src: W: spelling-error %description -l en_US fbsetbg -> setback,
subset, besetting
cwallpaper.src: W: spelling-error %description -l en_US bsetbg -> subset,
setback, basset
cwallpaper.src: W: spelling-error %description -l en_US esetroot -> beetroot,
esotropia, restroom
cwallpaper.src: W: spelling-error %description -l en_US feh -> eh, fee, fen
cwallpaper.src: W: spelling-error %description -l en_US config -> con fig,
con-fig, configure
1 packages and 0 specfiles checked; 0 errors, 7 warnings.
________________________________________________________________________________

Koji builds from scratch:

F12: http://koji.fedoraproject.org/koji/taskinfo?taskID=2458445
F13: http://koji.fedoraproject.org/koji/taskinfo?taskID=2458454
F14: http://koji.fedoraproject.org/koji/taskinfo?taskID=2458463
F15: http://koji.fedoraproject.org/koji/taskinfo?taskID=2458480

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.