[Bug 622173] Review Request: gappa - Prove programs with floating-point or fixed-point arithmetic

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=622173

Martin Gieseking <martin.gieseking at uos.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.gieseking at uos.de

--- Comment #2 from Martin Gieseking <martin.gieseking at uos.de> 2010-09-10 13:58:46 EDT ---
Here are some more notes:

- you can drop the two variable definitions from %configure

- preserve the timestamp of file COPYING
  http://fedoraproject.org/wiki/Packaging_tricks#Convert_encoding_to_UTF-8

- use macros (%{_bindir}, %{_defaultdocdir}) in %install and %files

- instead of running your own test, I recommend to run the bundled testsuite
  (with "make check"). However, in order to ensure that rpmbuild fails on a
  test failure, the Makefile must be slightly adapted. 
  Here's a quick sed hack, but patching testsuite/Makefile.am accordingly 
  would be much better:
  sed -i 's/\( cat "$$logtmp"; \\\)/\1\n\texit 1; \\/' testsuite/Makefile

  Maybe upstream can add the "exit 1" (or something similar) to the sources.

- I suggest to replace the directory %{_defaultdocdir}/doc with the pdf manual 
  available from the upstream website http://gappa.gforge.inria.fr/gappa.pdf
  as the currently installed folders don't contain a usable manual but the
  sources required to build the manual. You can also try to build the pdf 
  file from these sources (requires dblatex and some additional tools).

- drop INSTALL from the docs

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.