[Bug 622173] Review Request: gappa - Prove programs with floating-point or fixed-point arithmetic

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=622173

--- Comment #3 from David A. Wheeler <dwheeler at dwheeler.com> 2010-09-10 17:43:12 EDT ---
Okay, I have addressed all the issues noted in comment 1 and comment 2.

The updated package is here:
Spec URL: http://www.dwheeler.com/SPECS/gappa.spec
SRPM URL: http://www.dwheeler.com/SRPMS/gappa-0.13.0-2.fc13.src.rpm

I changed the URL per comment 1.

Regarding comment 2:
- you can drop the two variable definitions from %configure

DONE

- preserve the timestamp of file COPYING
  http://fedoraproject.org/wiki/Packaging_tricks#Convert_encoding_to_UTF-8

DONE

- use macros (%{_bindir}, %{_defaultdocdir}) in %install and %files

DONE.  I also globally defined another macro to clean it up.

- instead of running your own test, I recommend to run the bundled testsuite
  (with "make check"). However, in order to ensure that rpmbuild fails on a
  test failure, the Makefile must be slightly adapted. 
  Here's a quick sed hack, but patching testsuite/Makefile.am accordingly 
  would be much better:
  sed -i 's/\( cat "$$logtmp"; \\\)/\1\n\texit 1; \\/' testsuite/Makefile
  Maybe upstream can add the "exit 1" (or something similar) to the sources.

DONE.

I kept my own test and ADDED the bundled testsuite; the more the merrier.

Instead of futzing with Makefile.am directly, I'm using the sed mod,
and have sent an email to the author asking that the upstream makefile
be changed.  In the long term it'd be best if *upstream* made the change.

- I suggest to replace the directory %{_defaultdocdir}/doc with the pdf manual 
  available from the upstream website http://gappa.gforge.inria.fr/gappa.pdf
  as the currently installed folders don't contain a usable manual but the
  sources required to build the manual. You can also try to build the pdf 
  file from these sources (requires dblatex and some additional tools).

DONE.

I can't build the PDF easily; it requires tools that aren't packaged.
If someone wants to package THOSE tools up, great.

- drop INSTALL from the docs

DONE.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.