[Bug 623425] Review Request: python-pyside - Python bindings for Qt4

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=623425

Orcan 'oget' Ogetbil <oget.fedora at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #23 from Orcan 'oget' Ogetbil <oget.fedora at gmail.com> 2010-09-12 01:29:15 EDT ---
The package looks good. I would add versioned deps for these 2 libraries
   BuildRequires:  shiboken-devel >= 0.5
   BuildRequires:  qt4-devel >= 4.5.0
as they are both quite recent. I found the numbers in the CMakeLists.txt file.

(In reply to comment #10)
> (In reply to comment #9)
> > ! rpmlint says
> >    python-pyside-devel.x86_64: W: no-documentation
> > Also the file ChangeLog contains developer oriented information.
> 

My above suggestion is still valid.

> > It seems like the directory doc/ contains some developer documentation. No?
> Looks like it needs Qt source tree to generate API documentation. Not sure how
> to solve this; what do you think? Bundling whole qt tarball with python-pyside
> source rpm would probably work, but I'm not sure if we want to go down that
> road.
> 
> In any case the docs are also available at  http://www.pyside.org/docs/pyside/
> 

I couldn't find a way to build the docs without pain either. I guess we need to
skip this for now.

> 
> > ! The Phonon test segfaults
> > 
> >    DEBUG: 186: .../builddir/build/BUILD/pyside-qt4.6+0.4.0/tests/run_test.sh:
> > line 13: 29595 Segmentation fault      (core dumped) $3 $4
> >    DEBUG: 186/189 Test #186: phonon_basic_playing_test
> > .......................***Failed    2.59 sec
> > 
> > I hope this is not significant.
> 
> It's not showing up in the scratch builds I posted above though. How did you
> get it to segfault?
> 

I just built it on my local machine. But I can't reproduce it with this last
SRPM.

Otherwise everything seems fine. No blockers.

------------------------------------------------
This package (python-pyside) is APPROVED by oget
------------------------------------------------

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.