[Bug 576758] Review Request: moovida-plugins-bad - Media Center

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=576758

--- Comment #4 from Hans de Goede <hdegoede at redhat.com> 2010-09-12 15:24:56 EDT ---
Hi,

Sorry for the long delay. I recently switched teams with in Red Hat and as such
have been overwhelmed with work a bit. Here is a full review of this package:

Full review:

Good:
- rpmlint checks return:
moovida-plugins-bad.src: W: invalid-url Source0:
http://www.moovida.com/media/public/moovida-plugins-bad-1.0.9.tar.gz HTTP Error
403: Forbidden
moovida-plugins-bad.noarch: W: no-documentation
2 packages and 0 specfiles checked; 0 errors, 2 warnings.
Well the one of the 403 error is not so good, so below
- package meets naming guidelines
- package meets packaging guidelines
- license (GPLv3) OK, text not %doc, but also not in upstream tarbal, so no
  problem, matches source
- spec file legible, in am. english
- source matches upstream
  Could not check, as the upstream url is giving 403 errors? I double
  checked the url and it is the one from upstreams download page.
  So I wilol just assume this is a temporary glitch and believe the tarbal in
  the srpm is the correct one.
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime

Approved!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.