[Bug 620898] Review Request: nxtrc - A program to interact with LEGO NXT via BlueTooth

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=620898

Martin Gieseking <martin.gieseking at uos.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.gieseking at uos.de

--- Comment #1 from Martin Gieseking <martin.gieseking at uos.de> 2010-09-14 15:48:55 EDT ---
Hi Damian,

your package looks almost fine. Just a few minor notes:

- remove "A" from the Summary

- drop "Requires: bluez-libs" (it's added automatically as a dependency)

- The manpage contains the invalid comment prefix ." instead of .\" 
  You can fix this with
  sed -i 's/^\." /.\\" /' nxtrc.1

- add file Readme.txt as %doc


$ rpmlint /var/lib/mock/fedora-13-x86_64/result/*.rpm
nxtrc.x86_64: E: explicit-lib-dependency bluez-libs
nxtrc.x86_64: W: manual-page-warning /usr/share/man/man1/nxtrc.1.gz 1: warning:
`"' not defined
3 packages and 0 specfiles checked; 1 errors, 1 warnings.


BTW, if you don't have a sponsor yet, I can sponsor you if you're willing to do
two or three informal reviews of other packager's submissions in order to show
a (basic) understanding of the packaging guidelines. This is important because
you're allowed to formally review and approve packages, once you're sponsored.
If you're still interested in joining the packager group, let me know. :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.